Repository navigation
fix(explorer): reclaim transferred buffers in the retained worker pool - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retained explorer's worker pool exhausted its two slots because a transferred ArrayBuffer returns as a different JavaScript object. Count outstanding transfers and accept correctly sized returns after the existing worker generation guard, allowing the pool to keep producing frames.
This publishes the two previously local repair/reconciliation commits and adds a repeated two-way transfer regression. The retained explorer's renderer dependency and publisher role are unchanged.
Validation: all 26 worker tests pass, including 12 position-transport tests. With remote main's original implementation substituted, both transfer regressions fail while the other ten tests pass; the repaired source was restored for the passing run. All four ADR records pass the index checker. No live deployment acceptance is claimed.