Repository navigation
[Cloud] strip UTF-8 BOM from agent-seed.env - #3727
Merged
Merged
Conversation
Bash treats the BOM as part of the variable name, so source .cursor/agent-seed.env fails and the documented demo seed cannot start. Co-authored-by: Guillaume De Saint Martin <GuillaumeDSM@users.noreply.github.com>
GuillaumeDSM
marked this pull request as ready for review
October 6, 2026 09:12
Cloud agents need the node web UI build. GitHub cloud-env-validate still installs ci-tentacles explicitly. Co-authored-by: Guillaume De Saint Martin <GuillaumeDSM@users.noreply.github.com>
GuillaumeDSM
enabled auto-merge (rebase)
October 6, 2026 09:28
Herklos
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for sending your pull request.
But first, have you included unit tests, and is your code PEP8 conformant? More details
Summary
Make the Cloud Agent install use the
ui-node-webprofile, and make.cursor/agent-seed.envsourceable by Bash.Solve the issue: #___
Changelog
environment.jsoninstall isPANTS_PANTSD=false OCTOBOT_CLOUD_PROFILE=ui-node-web bash .cursor/cloud-install.sh.cursor/agent-seed.envcloud-env-validatestill installsci-tentaclesWhat's new?
Cloud agents that follow
environment.jsonnow build the node web UI (ui-node-web) instead of stopping atci-tentacles.PANTS_PANTSD=falsekeeps the Pants daemon from reserving extra memory during install..cursor/agent-seed.envbegan with a UTF-8 BOM. Bash treated that byte as part of the first variable name, sosource .cursor/agent-seed.envfailed andbash .cursor/seed-agent.shcould not resolveuser/agent-seed. The variable values are unchanged.GitHub Actions
cloud-env-validatestill passesOCTOBOT_CLOUD_PROFILE=ci-tentaclesitself.Validation
Local
ui-node-webinstall passed twice (OCTOBOT_CLOUD_INSTALL_OK).bash .cursor/cloud-validate.sh --profile ui-node-web --jsonpassed. Simulated seed wroteuser/agent-seed(Kraken sim accounts). Node UI login with passphrasedemodemoshowed Seed kraken A and Seed kraken B. Draft buildbld-20261006-ca757bec-10d6-4724-8ad6-c0249b2814c5(fromdev) succeeded, and a fresh agent booted from that build passed version, tentacles, UI dist, andpytest tests/unit_tests/test_octobot_version.py(4 passed).