Repository navigation
feat(voice): answering cuts the announcement short (0.39.0) - #50
Conversation
An announcement still being spoken when its permission prompt or question is answered now stops instead of playing to the end. The announcer speaks in its own process group, watches the markers it is about, and kills the speech tree once none still waits. Speech gets its own TMPDIR so a cut leaves no WAV behind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
When a permission prompt or question is answered while its announcement is still being spoken, the announcement now stops instead of playing to the end.
_ds_voice_speak_announcementspeaks in a background job in its own process group (set -m) and polls the markers it is about every 0.2 s (the approved-Bash-commandpscheck once a second). Once none still carries the eventId it was armed with, it signals the group and every pid in the tree (GNUtimeoutaround the player makes its own group).TMPDIR=voice/ann/<timer-pid>, pruned when that pid is dead, so a cut leaves no WAV behind.answered: announcement cut short.Tests: two new cases in
tests/voice/run.sh(cut on answer; another session's answer does not cut). Voice suite 183/183 with flock andDS_VOICE_NO_FLOCK=1; queue and hooks-consistency pass.🤖 Generated with Claude Code
Summary by CodeRabbit