Repository navigation
Voice bar only in the speaking session; dimmed line elsewhere (0.34.0, live 0.4.0) - #45
Merged
Merged
Conversation
… live 0.4.0) - progress.json carries sessionId (Claude Code's id) and, for replies, the session's spoken name. - Explanations look the session up from sessions/<claude-pid>, recorded by the prompt hook (only when voice is set up or CLAUDE_PID makes it free). - devscope-live draws the bar and Stop only where $.session.id() matches; other windows show one dimmed line naming the session. No sessionId (older plugin): the bar shows everywhere, as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (15)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The voice progress bar is driven by one
~/.cache/devscope/voice/progress.json, which every Claude Code window's devscope-live mod reads. With several sessions open, all of them showed the bar (and a Stop button), whichever session was talking.What changed
Plugin (0.34.0)
progress.jsongainssessionId, the Claude Code session the speech is about. For replies,projectis now the session's spoken name ("api-service, rate limiter fix") rather than just the folder./devscope:voice explain) are started by a command that isn't told the session, so the prompt hook recordssessions/<claude-pid>→ session id andcli.sh saylooks it up.CLAUDE_PID, so plugin users who never touch voice pay no process-tree lookups. Records idle two days are pruned.devscope-live (0.4.0)
parseProgressreadssessionId(''when absent or malformed).isOwnSpeech: the full bar and Stop only where it matches$.session.id().🔊 api-service, rate limiter fix · reading the summary(otherSpeechLabel).sessionId(devscope older than 0.34.0) → bar everywhere, as before, so mixed versions keep working.Both manifests bumped (
devscope0.34.0,devscope-live0.4.0 in itsplugin.jsonandmarketplace.json). CHANGELOGs and theprogress.jsoncontract in CLAUDE.md updated.Testing
tests/voice/run.sh: 170 passed, 0 failed. 4 new: a reply's progress names its session; the prompt hook records the window's session; an explanation's progress names the session that asked; nothing is recorded without voice set up.claude plugin test mods/devscope-live: 58 pass. New: the bar in the speaking session vs the dimmed line (no Stop, no bar) in another;sessionIdparsing and matching; the dimmed label.claude plugin validate mods/devscope-livepasses; other suites and hooks consistency pass.🤖 Generated with Claude Code
Summary by CodeRabbit