Repository navigation
feat(voice): playback_volume, louder speech on this computer only (0.30.0) - #41
Merged
Merged
Conversation
…30.0) voice.json `playback_volume` (0.5-3, default 1) is passed to pw-play, paplay and afplay, so DevScope's speech can be louder without turning up the system output. speed and playback_volume share one clamp helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> DevScope-Session: a06511a5-40bb-44f6-9a03-16ef7f1f6f8a
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (7)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
playback_volumetovoice.json(0.5-3, default 1): how loud this computer plays DevScope's speech. Speech can be louder without raising the system output, which turns up every other sound too. The existingvolumestill sets how loud the server makes the audio.Changes
_ds_voice_playpasses the playback volume topw-play --volume,paplay --volume(in its 0-65536 units) andafplay -v;aplayhas no volume option and plays as received._ds_voice_num(number from voice.json, default when unset or not a number, clamped);_ds_voice_speednow uses it too.commands/voice.md, README), CHANGELOG, version 0.30.0 in plugin.json and marketplace.json.tests/voice/run.sh: each player's arguments, the default, clamping, a non-number value.Testing
bash tests/voice/run.sh: 141 passed, 0 failed (main: 134). Run with stub players onPATH, because some existing tests fall back to the system voice (spd-say) and play through the real speakers.pw-play --volume 2.5accepted;/devscope:voice testthrough the branch's CLI atplayback_volume1.4.afplay -vnot run)Related issues
None.
🤖 Generated with Claude Code
DevScope-Session: a06511a5-40bb-44f6-9a03-16ef7f1f6f8a