Skip to content

feat(voice): playback_volume, louder speech on this computer only (0.30.0) - #41

Merged
DowLucas merged 1 commit into
mainfrom
feat/voice-playback-volume
Oct 7, 2026
Merged

DowLucas merged 1 commit into
mainfrom
feat/voice-playback-volume

Conversation

@DowLucas

@DowLucas DowLucas commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Summary

Adds playback_volume to voice.json (0.5-3, default 1): how loud this computer plays DevScope's speech. Speech can be louder without raising the system output, which turns up every other sound too. The existing volume still sets how loud the server makes the audio.

Changes

  • _ds_voice_play passes the playback volume to pw-play --volume, paplay --volume (in its 0-65536 units) and afplay -v; aplay has no volume option and plays as received.
  • New _ds_voice_num (number from voice.json, default when unset or not a number, clamped); _ds_voice_speed now uses it too.
  • Docs (commands/voice.md, README), CHANGELOG, version 0.30.0 in plugin.json and marketplace.json.
  • 7 tests in tests/voice/run.sh: each player's arguments, the default, clamping, a non-number value.

Testing

  • bash tests/voice/run.sh: 141 passed, 0 failed (main: 134). Run with stub players on PATH, because some existing tests fall back to the system voice (spd-say) and play through the real speakers.
  • Tested on Linux: pw-play --volume 2.5 accepted; /devscope:voice test through the branch's CLI at playback_volume 1.4.
  • Tested on macOS (afplay -v not run)
  • Hook scripts exit quickly and suppress errors
  • No credentials or sensitive data introduced

Related issues

None.

🤖 Generated with Claude Code
DevScope-Session: a06511a5-40bb-44f6-9a03-16ef7f1f6f8a

…30.0)

voice.json `playback_volume` (0.5-3, default 1) is passed to pw-play,
paplay and afplay, so DevScope's speech can be louder without turning up
the system output. speed and playback_volume share one clamp helper.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DevScope-Session: a06511a5-40bb-44f6-9a03-16ef7f1f6f8a
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0920dcea-f9e9-4c3d-adcc-b67a1cd57979
📥 Commits

Reviewing files that changed from the base of the PR and between 88bd106 and 706a8eb.

📒 Files selected for processing (7)
  • .claude-plugin/marketplace.json
  • .claude-plugin/plugin.json
  • CHANGELOG.md
  • README.md
  • commands/voice.md
  • scripts/voice/lib.sh
  • tests/voice/run.sh
 __________________________________________________________________________________
< Controlling complexity is the essence of computer programming. - Brian Kernighan >
 ----------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DowLucas
DowLucas merged commit 602eb5b into main Oct 7, 2026
10 of 11 checks passed
@DowLucas
DowLucas deleted the feat/voice-playback-volume branch October 7, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant