Repository navigation
feat(voice): quiet while the screen is locked; no mid-sentence splits (0.26.0) - #37
Merged
Merged
Conversation
… (0.26.0) Screen lock (when_locked: quiet by default, `when-locked play` to ignore): - detected locally: macOS ioreg CGSSessionScreenIsLocked or the screensaver; Linux logind LockedHint of the user's graphical session; anything unreadable (SSH, servers, lockers without LockedHint) counts as unlocked, so speech plays as before there; - announcements are held and said soon after unlock (reminder count untouched), auto voice is skipped, an explanation stops before its next piece; status shows the screen state. Pieces: every summary over 200 characters was voiced as two or three recordings, with a pause and restarted intonation between them, and cut mid-phrase where no sentence ended in time. Text that fits one voice-audio request (440) is now one piece; longer text splits only between sentences, and a single overlong sentence at a comma/semicolon/colon. Tests: 112 pass (lock detection on fake loginctl/ioreg for Linux and macOS, each kind of speech while locked, the override, splitting). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (11)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quiet while the screen is locked
DevScope only talks to someone at the computer. While the screen is locked:
ioreg -n Root -d1→"CGSSessionScreenIsLocked"=Yes, orScreenSaverEnginerunning.LockedHintof the user's graphical session (loginctl show-user $USER -p Display), so it is right even when Claude Code runs over SSH on the same machine.LockedHint(bare i3lock). These limits were agreed./devscope:voice when-locked quiet|play(defaultquiet), andstatusshowsScreen: locked|unlocked.No more pauses mid-sentence in summaries (bug)
Every summary over 200 characters was voiced as two or three separate recordings, with a pause and restarted intonation between them. A phrase was also cut wherever no sentence ended within the limit. Now:
(Mid-word cuts from the length cap were a separate bug, fixed server-side in DowLucas/devscope#84.)
Documented
README ("Locked screen", piece splitting), the
/devscope:voicehelp, CLAUDE.md (detection, hook points, test hooks, limits), CHANGELOG.Test plan
bash tests/voice/run.sh: 112 pass. New: Linux and macOS detection via fakeloginctl/ioreg; unlocked without logind; held announcement said after unlock with its count untouched; auto voice skipped; explanation stops mid-way;playoverride; status; one-piece summaries; comma splits.claude plugin validate .passes.ioreg -n Root -d1 | grep CGSSessionScreenIsLockedwhile locked showsYes.🤖 Generated with Claude Code
Summary by CodeRabbit