feat(sql-plan): digit-leading canonical_name is a physical output column - #24
Merged
dmautz1 merged 1 commit intoSep 1, 2026
Conversation
Extends the leading-underscore physical-name convention: a canonical_name
beginning with a digit is also an identifier the UMF name pattern cannot
carry (30DayCollectedAmount stored under Day30CollectedAmount) and is
emitted as the physical column everywhere. Display canonicals ('EHR #')
still never reach SQL. All three emission sites now share one helper.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the leading-underscore physical-name convention: a
canonical_namebeginning with a digit is also an identifier the UMFnamepattern (^[A-Za-z][A-Za-z0-9_]*$) cannot carry — e.g. a production table whose physical column is30DayCollectedAmount, authored under the UMF-safe nameDay30CollectedAmount. Such canonicals are now emitted as the physical column at every SQL surface (base view, joins, expression rewriting, final assembly), exactly like_invoice/u_invoice. Display canonicals ('EHR #') still never reach SQL.All three emission sites now share one
_physical_column_namehelper. Regression tests cover the digit-leading emission and the display-canonical non-emission.Full local gate passes: format-check, lint, type-check, 3879 tests incl. DuckDB/Spark conformance.
🤖 Generated with Claude Code