ENG-2040 Test the generic upsert route#1238
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1d74bdc to
6fcdca7
Compare
7a0f0f5 to
2c5ad8e
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mdroidian
left a comment
mdroidian
left a comment
There was a problem hiding this comment.
Do we want to start Next for the entire database Cucumber suite? Only addGeneric.feature needs it, so this adds another startup dependency and failure mode to every database test.
I think the route-level coverage is worthwhile, but I’d isolate it in a separate command/job that starts Next and runs only this feature. The regular database suite could remain Supabase-only. We should also poll an HTTP health check instead of relying on the "Ready in " console output.
Also, are we missing relationTypeSchemas?
| const servingReady = new Promise((rsc, rjc) => { | ||
| resolveCallback = rsc; | ||
| rejectCallback = rjc; | ||
| // Add timeout |
| // Add timeout | ||
| this.timeoutClear = setTimeout(() => { | ||
| rjc(new Error("Timeout waiting for functions to serve")); | ||
| }, 30000); // 30 second timeout |
| console.error("Could not kill the process"); | ||
| // maybe it just ended on its own. | ||
| } | ||
| if (nextServer.process.pid) |
There was a problem hiding this comment.
On Windows process.kill(-pid) returned ESRCH and left the detached child alive, leaking port 3000.
| ], | ||
| "relations": [ | ||
| { | ||
| "name": "a supports relation", |
There was a problem hiding this comment.
Should this match CrossAppRelation?
2c5ad8e to
109ed57
Compare
0dcfe78 to
9817046
Compare
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
9817046 to
a0ebf12
Compare
109ed57 to
a039e33
Compare
2 participants
https://linear.app/discourse-graphs/issue/ENG-2040/test-the-generic-upsert-route
https://www.loom.com/share/7a958930a0e641d0b5552f42bb2863f2
Added after the loom: I also now have to start the next server in the GitHub test database action.