ENG-2032 Disable sidebar open not respected

[mdroidian]

Problem

The "Disable sidebar open" setting was not being respected when creating new discourse nodes. New nodes would still open in the sidebar even when the setting was enabled.

Solution

Made the setting check more robust and added visual confirmation:

1. Robust Setting Check

   • Store the setting value in a variable for explicit checking
   • Use strict equality (=== true) instead of truthy evaluation
   • Ensures the setting is respected in all cases, including when the value might be undefined

2. Visual Confirmation

   • Show a brief toast notification when a node is created with the setting enabled
   • Provides clear feedback to users that the setting is working
   • Non-intrusive: uses primary intent and 2-second timeout

Technical Details

The issue was in the handleOpenInSidebar function within createDiscourseNode.ts. The original check used truthy evaluation which could potentially cause issues if the setting value was undefined or had unexpected values.

The fix ensures that:

• The sidebar only opens when the setting is explicitly false or undefined (default behavior)
• The sidebar is properly disabled when the setting is true
• Users get visual feedback confirming the setting is working

Changes

Before:

if (getPersonalSetting<boolean>([PERSONAL_KEYS.disableSidebarOpen])) return;

After:

const disableSidebarOpen = getPersonalSetting<boolean>([
  PERSONAL_KEYS.disableSidebarOpen,
]);
if (disableSidebarOpen === true) {
  renderToast({
    id: "sidebar-open-disabled",
    content: "Node created (sidebar open disabled in settings)",
    intent: "primary",
    timeout: 2000,
  });
  return;
}

Testing

All node creation pathways go through the createDiscourseNode function:

• Node menu (Ctrl+Shift+N)
• Command palette "Create discourse node"
• Canvas node creation
• Text selection popup / tag detection

All these pathways now:

1. Properly respect the "Disable sidebar open" setting
2. Show a confirmation toast when the setting prevents sidebar opening

User Experience

When a user has "Disable sidebar open" enabled and creates a new node:

• ✅ Node is created successfully
• ✅ Sidebar does NOT open
• ✅ Brief toast confirms: "Node created (sidebar open disabled in settings)"

This provides clear feedback that the setting is working as intended.

Linear Issue: ENG-2032

  

[linear-code]

ENG-2032

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Jul 20, 2026 3:33pm

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.