fix: mf-6835 keep external wallet connected after done and show provider icon - #12486
Open
swkatmask wants to merge 2 commits into
Open
fix: mf-6835 keep external wallet connected after done and show provider icon#12486swkatmask wants to merge 2 commits into
swkatmask wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MF-6835 regression from #12433/#12435 (built-in Mask wallet removal): connecting an external wallet from the popup appeared to work but never stuck, and every external wallet showed Mask's own logo.
handleDone: no longer callsEVMWeb3.disconnect({ providerType })— "Done" keeps the connection and just closes the popup window. Pre-removal, Done intentionally fell back to the built-in Mask wallet; with that gone, the disconnect tore down the connection the user just made. Persistence already works because non-background contexts proxy KV writes to the background, which broadcasts to all open contexts.WalletAvatar: for non-Firefly wallets, render the current EVM provider's icon (fromgetRegisteredWeb3Providersdescriptor) instead of always falling back toIcons.MaskBlue. MaskBlue remains the fallback when no descriptor matches.WalletHeaderUI: the header only renders when an account exists, so show the green dot +Connectedinstead of the hardcoded grey "Not Connected" (leftover from theuseConnectedremoval); drop the deadstatustransform on the network arrow.Test Plan
tsc --noEmit -p packages/maskcleanpnpm lintcleanCloses MF-6835