fix: mf-6831 use palette-adaptive text colors for token tag popper footer - #12485
Open
swkatmask wants to merge 1 commit into
Open
fix: mf-6831 use palette-adaptive text colors for token tag popper footer#12485swkatmask wants to merge 1 commit into
swkatmask wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
swkatmask
force-pushed
the
fix/mf6831-token-popper-footer-text-colors
branch
from
September 10, 2026 16:14
c95188e to
737ea96
Compare
swkatmask
force-pushed
the
fix/mf6831-token-popper-footer-text-colors
branch
from
September 10, 2026 16:28
4e44391 to
9a60fac
Compare
swkatmask
force-pushed
the
fix/mf6831-token-popper-footer-text-colors
branch
from
September 10, 2026 16:38
7090bd2 to
6d6fff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #12478 (MF-6831 round 1). The red packet part is confirmed fixed; on dark x.com the Web3 profile ($TAG hover) card footer text was still unreadable.
Design intent (confirmed): the card follows the site palette — in dark mode the body/footer are dark by design, and only the text needs to adapt. Round 1 switched the descriptor texts to
maskColor.publicMain(fixed#07101B), invisible on the popper's dark footer.Fix: pick the color token per surface, since the descriptor row renders on different backgrounds:
isTokenTagPopper=true) — the row is the card footer, which follows the site palette → palette-adaptivemaskColor.main(#07101Blight /#F5F5F5dark)isTokenTagPopper=false) — the row sits in the card's light header (hardcoded white gradient) → fixedmaskColor.publicMain(#07101B)Touched:
PluginDescriptor(title "Web3 Profile Card" / "DSearch"),TrendingViewDescriptor(selected data source + arrow icon). Card backgrounds/surfaces untouched.Test plan
pnpm devbuild, bundle verified (conditional compiled into the SiteAdaptor chunk)$BTC→ popper keeps white header + dark body/footer, "Web3 Profile Card" / "Powered by CoinGecko" now near-white and readable; tabs and stats readable$MASKsearch) header — "DSearch" and "CoinGecko" render dark on the light header (computedrgb(7,16,27))