Repository navigation
fix: release scenario bug-by-person-merges fails - #879
Conversation
The draft pull request opens before any code: the Spec as its checklist.
|
The pull request's board
🤖 AI-generated · Claude Opus 5.5 (Anthropic) |
Since #842, G7 asks each criterion's test to be run by a required check green at the head. In the test repository the fixed change's file, scenarios/<scenario>/<n>.test.md, is the criterion's only test and is among the pack's not-tests, so no check runs it and bug-by-person-merges never merged. check_evidence now passes the fixed change's pattern (test repository only), and criteria_unmet meets a test that is that pattern's file by being written and changed by the pull request; every other test, and every other repository, is unchanged. Assisted-by: Claude Opus 5.5 (Anthropic)
|
The autopilot ticked every criterion but ended without finishing. The checks ( 🤖 AI-generated · Claude Opus 5.5 (Anthropic) |
|
The autopilot ended without a result. The agent finished without marking the pull request ready or saying why it stopped. Nothing was marked ready and the agent left no stop comment, so a person takes it from here ( 🤖 AI-generated · Claude Opus 5.5 (Anthropic) |
|
@soydiloreto: a person takes it from here ( 🤖 AI-generated · Claude Opus 5.5 (Anthropic) |
Claude review · risk high · complexity medium · type fixNothing that must be fixed · 1 minor The fix lets G7 treat the test repository's fixed-change file (
Policy floor: high (touches high-risk paths: kinds/README.md, kinds/engine-test/pack.yml, scripts/autopilot.py, tests/workflows/test_fixed_change_required_check.py). Reviewed 024f791 (whole pull request; review 1 of 5 automatic). Author trusted for auto-merge: false. 🤖 AI review · claude-sonnet-5-5 (Anthropic) · $0.27, 7 turns |
📝 What changes
The cause: since #849 (#842), G7 (
scripts/autopilot.py decide, withcheck_evidencealways passed by thedecidecommand) requires each criterion's test to be run by a required check that concludedsuccessat the head (criteria_unmet→check_of). In the test repository the autopilot's fixed change (kinds/engine-test/pack.ymlfixed-change.file,scenarios/{scenario}/{n}.test.md) is the criterion's only "test", and the same pack listsscenarios/**intest-first.not-tests, socheck_ofreturns None and G7 answers "C1: no required check runsscenarios/bug-by-person-merges/<n>.test.md(G6)". The autopilot'sfix/<n>-…pull request never merges by policy, andbug-by-person-mergesends with its issue OPEN.tests/repro/test_issue_834.pystill passes because it callsdecidewithouthead_checks(the old callers' path), which is why nothing caught it.The fix (recommended, option A):
check_evidence(env, repo)also returns the fixed change's pattern,fixed_file(org.load(), repo)(non-empty only in the test repository whose pack saysautopilot: fixed-change), anddecide/criteria_unmettake it asfixed="": a criterion whose present test is that pattern's file (the pattern with{n},{id},{scenario}read as one path segment) is met by being written and changed by the pull request, as before #849, with no required check asked of it, since it is a file the fixed change writes and no check can run. Everywhere else (fixedempty) G7 is unchanged, and in the test repository any other path still needs its required check green.decide's reason says when a criterion was met by the fixed change. The pack's comment onfixed-changeand kinds/README.md'sfixed-changerow say so;scripts/autopilot.py --testgets a check for it.Options considered and not recommended:
test-first:with acheck:(e.g. the test repository'spipelinecheck). Wrong:pipelineneedsauto-merge, the job that runsdecide, so G7 would wait on itself; and no check actually runs a.mdfile.tests/repro/that a required check runs. Leaves each scenario's own directory (the core partition of fix: release scenarios wait in core, look duplicate and commit unsigned #709,release-scenarios.py core_problems), and makes "Test first" run it at the base for every scenario; much larger than the PRD's scope.This widens no permission, secret, lane or limit outside the test repository; inside it, G7 stops asking a required check of the fixed change's own file only (the pull request body will say so).
💡 Why
Closes #860. The autopilot works it here in the open: one commit per criterion, each box ticked once its commit is pushed.
🎯 Acceptance criteria
bug-by-person-mergesin the test repository, then it passes and the lane releases it.Test: tests/workflows/test_fixed_change_required_check.py (builds the decide step's evidence files as the workflow writes them for the test repository, with the head's required checks green, and the fixed Spec of a person's Normal Bug from
bug-by-person-merges; callscheck_evidenceanddecideas thedecidecommand does, and asserts it merges by policy; at the base it fails with "no required check runsscenarios/bug-by-person-merges/<n>.test.md")🧭 Decisions
🙌 Credits
🧪 How I tested it
The required checks ran at 024f791 and passed: Scripts (self-tests), Test first (the test fails at the base and passes at the head), actionlint and the conventions, in https://github.com/DiluxOne/.github/actions/runs/44599924946. A maintainer marked this pull request ready: the autopilot at
v7(v7.18.0) refuses to finish a release lane's bug, because it reads a reproduction test from the PRD and this issue has only the lane's scenario. Reading the scenario as the evidence (scenario_evidence) is on main since #836, not in v7.18.0, and it ships in the release this fix unblocks.🤖 AI-generated · Claude Opus 5.5 (Anthropic)