Handle synchronization blocks when calculating vector counts - #48
Open
SolarisCulture wants to merge 1 commit into
Open
Handle synchronization blocks when calculating vector counts#48SolarisCulture wants to merge 1 commit into
SolarisCulture wants to merge 1 commit into
Conversation
- Add SyncBlock to the zero-vector cases TestOVF.cs or a dedicated test file - Unit test for VectorCount - Write/read integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronization blocks contain no coordinate vectors, but VectorBlockExtensions.VectorCount did not handle SyncBlock. It therefore threw NotImplementedException while OVFFileWriter calculated work-plane bounds during file finalization.
This change treats SyncBlock like ExposurePause and returns a vector count of zero.
Tests added: