Repository navigation
Add optional mounts - #83
Merged
Merged
Conversation
When defining a list of mounts, you can now specify an 'optional_mount'. These are checked in the apptainer_entrypoint to see if the path exists. If not, then a warning is sent to stderr and the mount is excluded from the apptainer mount list.
ptsOSL
reviewed
Sep 22, 2026
ptsOSL
left a comment
ptsOSL
left a comment
Collaborator
There was a problem hiding this comment.
I think the premise is good, just a few details to improve on
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 99.48% 99.39% -0.10%
==========================================
Files 27 27
Lines 978 993 +15
==========================================
+ Hits 973 987 +14
- Misses 5 6 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MichaelStubbings
marked this pull request as ready for review
September 28, 2026 09:20
MichaelStubbings
changed the title
ptsOSL
previously approved these changes
Sep 28, 2026
ptsOSL
left a comment
ptsOSL
left a comment
Collaborator
There was a problem hiding this comment.
Thats a nice and easy way to prioritise the local entrypoint mounts. I am happy with these changes. Is it worth adding a test to check that the local entrypoint mounts are prioritised?
MJGaughran
reviewed
Sep 28, 2026
The solution in apptainer_app.py removed entries from the mounts list, which would affect all defined entrypoints. This solution ensures that each entrypoints mounts are resolved independently from each other
MichaelStubbings
force-pushed
the
hla-1167-handle-invalid-mounts
branch
from
September 30, 2026 09:14
5582a4c to
621ddc7
Compare
MichaelStubbings
force-pushed
the
hla-1167-handle-invalid-mounts
branch
from
September 30, 2026 10:52
621ddc7 to
31dad3b
Compare
MJGaughran
reviewed
Sep 30, 2026
MJGaughran
left a comment
MJGaughran
left a comment
Contributor
There was a problem hiding this comment.
I only noticed a minor mistake in the comment. Otherwise, how exactly did you verify that this is backwards-compatible with the existing configuration & deployment?
MJGaughran
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional mounts.
When an optional mount is invalid, it will exclude it from the mount list so it does not cause an error. This handles all types of mounting syntax, such as:
e.g. Using the options:
As part of this PR, we decided to make it so that the entrypoint mounts always take precedence over the global. This allows someone to define a path as 'required' globally, but 'optional' for specific entrypoints. (and vice versa).