Resolve WinGet source refresh issues and bump version to 0.12.0 - #44
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
September 9, 2026 15:43
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Mirror freshness can be bypassed or incorrectly extended, and some storage failures still escape the cached-query fallback.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves WinGet executable resolution and source-mirror reliability while releasing version 0.12.0.
Changes:
- Adds configurable, fallback-based WinGet discovery in Rust and C#.
- Adds mirror freshness caching, failure warnings, and tests.
- Updates documentation and package versions.
File summaries
| File | Description |
|---|---|
README.md |
Documents WinGet resolution and mirror behavior. |
rust/crates/pinget-core/src/lib.rs |
Implements Rust resolution, caching, and tests. |
rust/crates/pinget-core/Cargo.toml |
Bumps core to 0.12.0. |
rust/crates/pinget-com/Cargo.toml |
Bumps COM bridge to 0.12.0. |
rust/crates/pinget-cli/Cargo.toml |
Bumps CLI and core dependency. |
nuget/Devolutions.Pinget.Cli.Rust/Devolutions.Pinget.Cli.Rust.csproj |
Bumps Rust CLI package. |
nuget/Devolutions.Pinget.Cli.DotNet/Devolutions.Pinget.Cli.DotNet.csproj |
Bumps .NET CLI package. |
dotnet/src/Devolutions.Pinget.PowerShell.Engine/PowerShellEngineVersion.cs |
Updates engine version. |
dotnet/src/Devolutions.Pinget.PowerShell.Cmdlets/ModuleFiles/Devolutions.Pinget.Client.psd1 |
Updates module version. |
dotnet/src/Devolutions.Pinget.Core/SystemWingetSourceStore.cs |
Adds WinGet discovery and invocation handling. |
dotnet/src/Devolutions.Pinget.Core/SourceStore.cs |
Adds mirror freshness checking. |
dotnet/src/Devolutions.Pinget.Core/Repository.cs |
Adds cached query refresh and warnings. |
dotnet/src/Devolutions.Pinget.Core.Tests/CoreTests.cs |
Tests resolution and mirror behavior. |
dotnet/src/Devolutions.Pinget.Cli/Program.cs |
Updates CLI version. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improved handling for locating and invoking the system WinGet executable, enhances the reliability of source mirroring, and adds comprehensive test coverage for these behaviors. It also updates documentation and bumps the CLI version. The most important changes are grouped below:
System WinGet Executable Resolution and Usage:
PINGET_WINGET_PATH, allowing explicit configuration of the WinGet executable or its containing directory. The resolution order now checks this variable first, then the application directory, PATH,%LOCALAPPDATA%\Microsoft\WindowsApps, and finally the newest registered App Installer package root. This logic is now shared between the Rust CLI and C# core. [1] [2]SystemWingetSourceStoreto use the resolved WinGet executable path instead of assuming a static name.Source Mirror Caching and Query Reliability:
README.mddescribing the new WinGet resolution process and improved explanation of source mirroring and fallback behavior.Testing and Versioning:
0.12.0to reflect these significant changes.