Repository navigation
fix(picky-asn1-der): Avoid integer overflow when computing DER object length - #587
Open
idhyt (idhyt) wants to merge 1 commit into
Open
idhyt (idhyt) wants to merge 1 commit into
idhyt (idhyt) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Use
checked_addinstead of+when computing the length forSequence::deserialize_lazyindeserialize_enum, so thatextremely large DER long-form length values produce a
TruncatedDataerror instead of wrapping or overflowing.Why
Length::deserializedcan returnusize::MAXfor a valid-lookingbut extremely large DER long-form length field (e.g.
0x88 0xFF…0xFF).With plain
+arithmetic,1 + usize::MAXwraps (or panics underoverflow checks), resulting in a bogus length being passed downstream.
Before / After
Validation
cargo test --libpassed (6 tests, including a new regression test)cargo fmt -- --checkcleancargo clippy --all-targets --all-features -- -D warningscleandeserialize_enum_rejects_oversized_lengthcovering an extremely large DER long-form length field