Skip to content

Keep the Windows editor within one monitor - #23

Merged
Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
masterfrom
copilot/editor-window-placement
Nov 2, 2026
Merged

Marc-André Moreau (mamoreau-devolutions) merged 2 commits into
masterfrom
copilot/editor-window-placement

Conversation

@mamoreau-devolutions

Copy link
Copy Markdown
Contributor

Summary

  • Center the editor on the pointer's monitor on first opening, limited to 90% of its usable work area and the preferred 1500 × 960 logical-pixel size.
  • Remember normal bounds, display DPI, and maximized state in a separate settings section.
  • Fit restored and moved windows to one monitor after monitor, taskbar, and DPI changes; preserve normal bounds while minimized and avoid fighting an active drag.
  • Document the placement behavior and add focused geometry and native-window regression tests.

Verification

  • cargo test -p jiffshot editor_placement -- --nocapture: 7 passed.
  • cargo build -p jiffshot: passed.
  • Isolated Avalonia UI fixture confirmed Copy All stays visible, maximize/restore state is saved, and a cross-monitor move is corrected. The user's existing app and capture were left untouched.
  • git diff --check: passed.
  • Strict Clippy was attempted, but is blocked by pre-existing lints in the document crate and other app modules; no diagnostics were reported in the new placement module.

Physical monitor disconnect/reconnect and live display-scale changes were not manually exercised; their geometry cases are covered by regression tests.

Remember editor size, position, DPI and maximized state; fit restored and moved windows to a single monitor work area.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use sample-based encoder timestamps so small overlaps at recording pause boundaries cannot shorten MP4 media and fail gapless finalization. Add deterministic overlap and partial-frame regressions that verify decoded sample counts, timestamps and tone alignment.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) merged commit 9d8b574 into master Nov 2, 2026
16 checks passed
@mamoreau-devolutions
Marc-André Moreau (mamoreau-devolutions) deleted the copilot/editor-window-placement branch November 2, 2026 14:09
Marc-André Moreau (mamoreau-devolutions) added a commit that referenced this pull request Nov 2, 2026
## Summary
- Remove all 19 exhaustive Linux GUI suites from CI on both x64 and
ARM64, including master, manual, and release runs.
- Keep the scripts under `app/tests` available for local execution.
- Retain native builds, workspace tests, Clippy, packaging checks, and
portable/installed-package startup smoke tests.
- Update the README to match.

## Timing evidence
In #23's successful CI run
(https://github.com/Devolutions/jiffshot/actions/runs/41456865707),
these suites consumed 9m04s on Linux x64 and 8m03s on Linux ARM64.
Removing them eliminates approximately 9 minutes from that run's
critical path and 17 minutes of combined runner time; the new end-to-end
duration has not yet been measured.

## Validation
- Parsed the workflow YAML and verified that exactly the 19 intended GUI
steps were removed.
- Compared the parsed workflow with the previous version after excluding
those steps: all other CI behavior is unchanged.
- `git diff --check` passes.

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant