Skip to content

fix(agent-installer): secure policy migration #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benoît Cortier (CBenoit) wants to merge 9 commits into from
+2,322 −2
Open

fix(agent-installer): secure policy migration #1979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bc30053
fix(agent-installer): secure policy migration
CBenoit Sep 8, 2026
9185bcc
test(agent-installer): cover policy migration
CBenoit Sep 8, 2026
e699348
fix(agent-installer): address review feedback
CBenoit Sep 8, 2026
e6a9e3a
fix(agent-installer): harden migration cleanup
CBenoit Sep 8, 2026
5201d7e
fix(agent-installer): make commit cleanup best-effort
CBenoit Sep 8, 2026
1966fc8
fix(agent-installer): preserve migration collisions
CBenoit Sep 8, 2026
8e2f5dd
fix(agent-installer): read bound migration temporary
CBenoit Sep 8, 2026
0e87ab8
fix(agent-installer): probe legacy YAML safely
CBenoit Sep 8, 2026
3578b30
fix(agent-installer): restrict configured policy paths
CBenoit Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,21 @@ jobs:
run: dotnet test utils/dotnet/GatewayUtils.sln
shell: pwsh

agent-installer-tests:
name: Agent installer tests
runs-on: windows-2022
needs: [preflight]

steps:
- name: Checkout ${{ github.repository }}
uses: actions/checkout@v6
with:
ref: ${{ needs.preflight.outputs.ref }}

- name: Tests
run: dotnet test package/AgentWindowsManaged.Tests/DevolutionsAgent.Installer.Tests.csproj
shell: pwsh


winapi-sanitizer-tests:
name: Windows API sanitizer tests
Expand Down Expand Up @@ -1357,7 +1372,7 @@ jobs:
success:
name: Success
if: ${{ always() }}
needs: [tests, agent-tunnel-e2e, agent-policy-e2e, lints, check-dependencies, jetsocat-lipo, devolutions-gateway-powershell, devolutions-gateway, devolutions-gateway-merge, devolutions-pedm-desktop, devolutions-agent, devolutions-agent-merge, devolutions-pedm-client, dotnet-utils-tests, winapi-sanitizer-tests, winapi-miri, pedm-simulator, secure-memory-verifier]
needs: [tests, agent-tunnel-e2e, agent-policy-e2e, lints, check-dependencies, jetsocat-lipo, devolutions-gateway-powershell, devolutions-gateway, devolutions-gateway-merge, devolutions-pedm-desktop, devolutions-agent, devolutions-agent-merge, devolutions-pedm-client, dotnet-utils-tests, agent-installer-tests, winapi-sanitizer-tests, winapi-miri, pedm-simulator, secure-memory-verifier]
runs-on: ubuntu-latest

steps:
Expand Down
21 changes: 21 additions & 0 deletions package/AgentWindowsManaged.Tests/DevolutionsAgent.Installer.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net48</TargetFramework>
<LangVersion>latest</LangVersion>
<IsPackable>false</IsPackable>
<AssemblyName>DevolutionsAgent.Installer.Tests</AssemblyName>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.1.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\AgentWindowsManaged\DevolutionsAgent.csproj" Targets="CoreBuild;GetTargetPath" />
</ItemGroup>
</Project>
Loading
Loading