Skip to content

perf(jmux,jetsocat): reuse sender flush timer #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benoît Cortier (CBenoit) merged 1 commit into from
Aug 5, 2026
+5 −1
Merged

perf(jmux,jetsocat): reuse sender flush timer #1909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/jmux-proxy/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ pub use self::event::{EventOutcome, TrafficEvent, TransportProtocol};

const MAXIMUM_PACKET_SIZE_IN_BYTES: u16 = 4 * 1024; // 4 kiB
const WINDOW_ADJUSTMENT_THRESHOLD: u32 = 4 * 1024; // 4 kiB
const JMUX_FLUSH_DELAY: core::time::Duration = core::time::Duration::from_millis(10);

// The JMUX channel will require at most `MAXIMUM_PACKET_SIZE_IN_BYTES × JMUX_MESSAGE_CHANNEL_SIZE` bytes to be kept alive.
const JMUX_MESSAGE_MPSC_CHANNEL_SIZE: usize = 512;
Expand Down Expand Up @@ -384,6 +385,8 @@ impl<T: AsyncWrite + Unpin + Send + 'static> JmuxSenderTask<T> {
let mut jmux_writer = tokio::io::BufWriter::with_capacity(16 * 1024, jmux_writer);
let mut buf = bytes::BytesMut::new();
let mut needs_flush = false;
let flush_timer = tokio::time::sleep(JMUX_FLUSH_DELAY);
tokio::pin!(flush_timer);

loop {
tokio::select! {
Expand All @@ -399,8 +402,9 @@ impl<T: AsyncWrite + Unpin + Send + 'static> JmuxSenderTask<T> {

jmux_writer.write_all(&buf).await?;
needs_flush = true;
flush_timer.as_mut().reset(tokio::time::Instant::now() + JMUX_FLUSH_DELAY);
}
_ = tokio::time::sleep(core::time::Duration::from_millis(10)), if needs_flush => {
_ = flush_timer.as_mut(), if needs_flush => {
jmux_writer.flush().await?;
needs_flush = false;
}
Expand Down
Loading