fix(agent): trust LOCAL SERVICE writes on broker security checks - #1906
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Pull request overview
Updates broker security checks to accept LOCAL SERVICE writes required by stock Agent installations.
Changes:
- Adds
LOCAL SERVICEas a trusted SID. - Adds regression tests for
LOCAL SERVICEandNETWORK SERVICE. - Updates security documentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Devolutions Agent installer creates C:\ProgramData\Devolutions\Agent with write access granted to LOCAL SERVICE. The broker's anti-tampering verification rejected such a DACL, so the policy file failed to load on stock installations. LOCAL SERVICE already holds elevated rights on the host, so trusting it does not extend the attack surface. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
LOCAL SERVICE is a low-privilege shared service identity, so it is only trusted for the policy file (AdminOnly mode), not for elevated executables where accepting it would open a privilege-escalation path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
952ca3e to
0945aff
Compare
88799db
into
master
Fixes the package broker policy file failing to load on stock installations.
The Agent installer creates
C:\ProgramData\Devolutions\Agentwith write access granted toLOCAL SERVICE, and the broker's anti-tampering verification rejected that DACL, preventing the policy from loading.LOCAL SERVICEalready holds elevated rights on the host, so trusting it does not extend the attack surface.NETWORK SERVICEremains untrusted (covered by a regression test).