Skip to content

update eslint 10, update eslint-config-next, create-next-app - #1286

Merged
vorobey merged 6 commits into
DevExpress:masterfrom
vorobey:chore/update-eslint
Nov 17, 2026
Merged

vorobey merged 6 commits into
DevExpress:masterfrom
vorobey:chore/update-eslint

Conversation

@vorobey

@vorobey vorobey commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vorobey
vorobey requested a balanced review from Copilot November 17, 2026 12:13
@vorobey vorobey self-assigned this Nov 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ESLint 10 override conflicts with locked plugin peer ranges across all eight Next.js fixtures, and a JavaScript fixture lockfile omits a required TypeScript peer, blocking regeneration and plain npm ci.

2 open issues
2 files not reviewed
  • pnpm-lock.yaml: Generated file
  • scripts/regenerate-nextjs-apps/package-lock.json: Generated file
What changed in this PR

This PR updates ESLint and Next.js tooling across the DevExtreme CLI workspace and its Next.js test fixtures.

Changes:

  • Upgrades workspace lint tooling to ESLint 10 and removes React/Vue test lint configurations and related dependencies.
  • Updates create-next-app to 16.4.6 and adjusts scaffolding and regeneration options.
  • Refreshes eight Next.js fixtures to Next.js 16.4.6, React 19.3.0, and updated lint dependencies.
File Description
scripts/​regenerate-nextjs-apps/​package.json Updates the pinned Next.js generator.
scripts/​regenerate-nextjs-apps/​package-lock.json Locks the updated generator.
scripts/​regenerate-nextjs-apps/​index.js Adds generator flags and an ESLint version override.
pnpm-workspace.yaml Adds an ESLint catalog entry.
pnpm-lock.yaml Refreshes workspace lint dependencies.
packages/​devextreme-schematics/​package.json Upgrades ESLint to version 10.
packages/​devextreme-cli/​testing/​lint-config/​vue.config.mjs Removes the Vue test lint configuration.
packages/​devextreme-cli/​testing/​lint-config/​react.config.mjs Removes the React JavaScript test lint configuration.
packages/​devextreme-cli/​testing/​lint-config/​react-ts.config.mjs Removes the React TypeScript test lint configuration.
packages/​devextreme-cli/​testing/​lint-config/​angular.config.mjs Uses the Angular plugin without the compatibility wrapper.
packages/​devextreme-cli/​src/​utility/​latest-versions.js Updates the CLI’s Next.js generator version.
packages/​devextreme-cli/​src/​applications/​application.nextjs.js Disables cache components and explicitly selects npm.
packages/​devextreme-cli/​package.json Updates lint tooling and removes related dependencies.
package.json Upgrades ESLint and removes Angular ESLint schematics.
apps/​nextjs-testing/​ts-src-pages/​package.json Updates the TypeScript Pages Router fixture with src.
apps/​nextjs-testing/​ts-src-app/​package.json Updates the TypeScript App Router fixture with src.
apps/​nextjs-testing/​ts-nosrc-pages/​package.json Updates the TypeScript Pages Router fixture without src.
apps/​nextjs-testing/​ts-nosrc-app/​package.json Updates the TypeScript App Router fixture without src.
apps/​nextjs-testing/​js-src-pages/​package.json Updates the JavaScript Pages Router fixture with src.
apps/​nextjs-testing/​js-src-pages/​package-lock.json Refreshes the fixture’s locked dependency tree.
apps/​nextjs-testing/​js-src-app/​package.json Updates the JavaScript App Router fixture with src.
apps/​nextjs-testing/​js-nosrc-pages/​package.json Updates the JavaScript Pages Router fixture without src.
apps/​nextjs-testing/​js-nosrc-app/​package.json Updates the JavaScript App Router fixture without src.
apps/​nextjs-testing/​.generator-meta.json Records generator version 16.4.6.

Review effort: Balanced

Comment thread scripts/regenerate-nextjs-apps/index.js Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Security-lint CI confirmation is needed because ESLint 10 exceeds transitive eslint-plugin-react’s declared peer support through ESLint 9, and dependency-backed runtime validation was unavailable.

1 open issue
1 resolved since last review
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

ESLint 10 compatibility with the security linter’s eslint-plugin-react dependencies remains unverified because their declared peer support ends at ESLint 9 and dependency-backed runtime validation was unavailable.

No open issues 🎉

1 resolved since last review
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

@vorobey
vorobey merged commit a20eb80 into DevExpress:master Nov 17, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants