Skip to content

PivotGrid - OldSortable - Fix strict eslint errors - #36398

Open
Tucchhaa wants to merge 2 commits into
DevExpress:mainfrom
Tucchhaa:pivotgrid_msortable_27_1
Open

Tucchhaa wants to merge 2 commits into
DevExpress:mainfrom
Tucchhaa:pivotgrid_msortable_27_1

Conversation

@Tucchhaa

Copy link
Copy Markdown
Contributor

No description provided.

@Tucchhaa Tucchhaa self-assigned this Nov 18, 2026
@Tucchhaa
Tucchhaa requested a review from a team as a code owner November 18, 2026 13:13
@Tucchhaa Tucchhaa added the 27_1 label Nov 18, 2026
Copilot AI balanced review requested due to automatic review settings November 18, 2026 13:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The export change leaves the field chooser’s expected Sortable constructor undefined, causing rendering to fail unless the alias is preserved or the consumer is updated.

1 open issue
What changed in this PR

This PR addresses strict ESLint errors in PivotGrid’s legacy sortable implementation by adding explicit types and refactoring its drag-and-drop code.

Changes:

  • Adds interfaces for sortable options, event arguments, item offsets, and scrolling.
  • Replaces loosely typed values and callbacks with explicit types and null checks.
  • Renames the internal class to OldSortable and updates its exports.
File Description
packages/​devextreme/​js/​__internal/​grids/​pivot_grid/​sortable/​types.ts Defines types for sortable configuration and drag-and-drop state.
packages/​devextreme/​js/​__internal/​grids/​pivot_grid/​sortable/​m_sortable.ts Applies strict typing and refactors handlers, geometry helpers, and class naming.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues blocking the PivotGrid sortable typing and lint refactor.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants