Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The broad accessibility-runner migration replaces TestCafe and changes interaction models, requiring human review of Playwright CI results across themes to confirm behavioral parity because browser execution was unavailable.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Migrates DevExtreme’s accessibility end-to-end tests from TestCafe to Playwright, integrating axe checks with Playwright fixtures and component page models.
Changes:
- Adds shared axe helpers, theme-aware configuration, and option-matrix test generation.
- Ports component accessibility scenarios and adds supporting page models, test data, and an extended container page.
- Removes the corresponding TestCafe tests, accessibility setup, dependencies, and CI matrix entries.
| File | Description |
|---|---|
pnpm-workspace.yaml |
Adds the Playwright axe dependency to the catalog. |
pnpm-lock.yaml |
Records accessibility dependency changes. |
e2e/testcafe-devextreme/tests/accessibility/validationSummary.ts |
Removes migrated ValidationSummary checks. |
e2e/testcafe-devextreme/tests/accessibility/treeList/common.ts |
Removes migrated TreeList checks. |
e2e/testcafe-devextreme/tests/accessibility/tooltip.ts |
Removes migrated Tooltip checks. |
e2e/testcafe-devextreme/tests/accessibility/toolbar.ts |
Removes migrated Toolbar checks. |
e2e/testcafe-devextreme/tests/accessibility/toast.ts |
Removes migrated Toast checks. |
e2e/testcafe-devextreme/tests/accessibility/tileView.ts |
Removes migrated TileView checks. |
e2e/testcafe-devextreme/tests/accessibility/switch.ts |
Removes migrated Switch checks. |
e2e/testcafe-devextreme/tests/accessibility/speechToText.ts |
Removes migrated SpeechToText checks. |
e2e/testcafe-devextreme/tests/accessibility/progressBar.ts |
Removes migrated ProgressBar checks. |
e2e/testcafe-devextreme/tests/accessibility/multiView.ts |
Removes migrated MultiView checks. |
e2e/testcafe-devextreme/tests/accessibility/loadPanel.ts |
Removes migrated LoadPanel checks. |
e2e/testcafe-devextreme/tests/accessibility/loadIndicator.ts |
Removes migrated LoadIndicator checks. |
e2e/testcafe-devextreme/tests/accessibility/htmlEditor.ts |
Removes migrated HtmlEditor and AI checks. |
e2e/testcafe-devextreme/tests/accessibility/floatingActionButton.ts |
Removes migrated floating-action checks. |
e2e/testcafe-devextreme/tests/accessibility/dataGrid/templates.ts |
Removes migrated row-template checks. |
e2e/testcafe-devextreme/tests/accessibility/dataGrid/status.ts |
Removes migrated grid status checks. |
e2e/testcafe-devextreme/tests/accessibility/dataGrid/scrolling.ts |
Removes migrated scrolling checks. |
e2e/testcafe-devextreme/tests/accessibility/dataGrid/editing.ts |
Removes migrated editor checks. |
e2e/testcafe-devextreme/tests/accessibility/contextMenu.ts |
Removes migrated ContextMenu checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/noData.ts |
Removes migrated empty-state checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/headerFilter.ts |
Removes migrated header-filter checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/filterPanel.ts |
Removes migrated filter-panel checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/editing.ts |
Removes migrated card-editing checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/cover.ts |
Removes migrated card-cover checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/columnSortable.ts |
Removes migrated column-dragging checks. |
e2e/testcafe-devextreme/tests/accessibility/cardView/columnChooser.ts |
Removes migrated column-chooser checks. |
e2e/testcafe-devextreme/tests/accessibility/button.ts |
Removes migrated Button checks. |
e2e/testcafe-devextreme/tests/accessibility/accordion.ts |
Removes migrated Accordion checks. |
e2e/testcafe-devextreme/runner.ts |
Removes accessibility-specific runner setup. |
e2e/testcafe-devextreme/package.json |
Removes TestCafe accessibility dependencies. |
e2e/testcafe-devextreme/helpers/testPageUtils.ts |
Removes axe loading and accessibility viewport helpers. |
e2e/testcafe-devextreme/helpers/accessibility/utils.ts |
Removes the TestCafe axe-check helper. |
e2e/testcafe-devextreme/helpers/accessibility/test.ts |
Removes the TestCafe accessibility test generator. |
e2e/playwright/tests/navigation/treeView/data.ts |
Adds hierarchical TreeView test data. |
e2e/playwright/tests/editors/chat/data.ts |
Adds an embedded chat avatar fixture. |
e2e/playwright/tests/dataGrid/helpers/generateDataSourceData.ts |
Adds generated grid test data. |
e2e/playwright/tests/container-extended.html |
Adds a themed container with Quill and Gantt assets. |
e2e/playwright/tests/common/filterBuilder/data.ts |
Adds FilterBuilder fields and expressions. |
e2e/playwright/tests/cardView/helpers/simpleArrayData.ts |
Adds shared CardView records and columns. |
e2e/playwright/tests/cardView/filterPanel/helpers/baseConfig.ts |
Adds shared filter-panel configuration. |
e2e/playwright/tests/cardView/columnSortable/utils.ts |
Adds drag-event helpers and column locators. |
e2e/playwright/tests/accessibility/validationSummary.spec.ts |
Ports ValidationSummary option checks. |
e2e/playwright/tests/accessibility/treeView.spec.ts |
Converts TreeView checks to Playwright. |
e2e/playwright/tests/accessibility/treeList/common.spec.ts |
Ports TreeList checks with readiness polling. |
e2e/playwright/tests/accessibility/treeList/aria.spec.ts |
Converts keyboard-expansion ARIA assertions. |
e2e/playwright/tests/accessibility/tooltip.spec.ts |
Ports Tooltip option checks. |
e2e/playwright/tests/accessibility/toolbar.spec.ts |
Ports Toolbar overflow-menu checks. |
e2e/playwright/tests/accessibility/toast.spec.ts |
Ports Toast type and message checks. |
e2e/playwright/tests/accessibility/tileView.spec.ts |
Ports focused TileView checks. |
e2e/playwright/tests/accessibility/textBox.spec.ts |
Converts TextBox checks and names configurations. |
e2e/playwright/tests/accessibility/textArea.spec.ts |
Converts TextArea checks and names configurations. |
e2e/playwright/tests/accessibility/tagBox.spec.ts |
Converts TagBox interactions and popup waits. |
e2e/playwright/tests/accessibility/tabs.spec.ts |
Converts Tabs checks and keyboard focus. |
e2e/playwright/tests/accessibility/tabPanel.spec.ts |
Converts TabPanel option checks. |
e2e/playwright/tests/accessibility/switch.spec.ts |
Ports Switch state checks. |
e2e/playwright/tests/accessibility/stepper.spec.ts |
Converts Stepper option checks. |
e2e/playwright/tests/accessibility/splitter.spec.ts |
Converts Splitter option checks. |
e2e/playwright/tests/accessibility/speechToText.spec.ts |
Ports SpeechToText option checks. |
e2e/playwright/tests/accessibility/slider.spec.ts |
Converts Slider checks and names appearance cases. |
e2e/playwright/tests/accessibility/selectBox.spec.ts |
Converts SelectBox checks with distinct configuration names. |
e2e/playwright/tests/accessibility/scheduler/status.spec.ts |
Converts Scheduler status and navigation assertions. |
e2e/playwright/tests/accessibility/scheduler/scheduler.spec.ts |
Converts Scheduler view, grouping, and ARIA checks. |
e2e/playwright/tests/accessibility/scheduler/axe_options.ts |
Exports shared Scheduler axe options. |
e2e/playwright/tests/accessibility/scheduler/appointmentForm.spec.ts |
Converts appointment-form checks with visibility assertions. |
e2e/playwright/tests/accessibility/rangeSlider.spec.ts |
Converts RangeSlider option checks. |
e2e/playwright/tests/accessibility/radioGroup.spec.ts |
Converts RadioGroup and interactive-item checks. |
e2e/playwright/tests/accessibility/progressBar.spec.ts |
Ports ProgressBar state checks. |
e2e/playwright/tests/accessibility/popup.spec.ts |
Converts visible and hidden Popup checks. |
e2e/playwright/tests/accessibility/popover.spec.ts |
Converts Popover checks and theme-dependent options. |
e2e/playwright/tests/accessibility/pivotGrid.spec.ts |
Converts PivotGrid and overlay interactions. |
e2e/playwright/tests/accessibility/pagination.spec.ts |
Converts Pagination test setup. |
e2e/playwright/tests/accessibility/numberBox.spec.ts |
Converts NumberBox option checks. |
e2e/playwright/tests/accessibility/multiView.spec.ts |
Ports MultiView option checks. |
e2e/playwright/tests/accessibility/menu.spec.ts |
Converts Menu checks and keyboard interactions. |
e2e/playwright/tests/accessibility/lookup.spec.ts |
Converts Lookup rendering configurations. |
e2e/playwright/tests/accessibility/loadPanel.spec.ts |
Ports LoadPanel option checks. |
e2e/playwright/tests/accessibility/loadIndicator.spec.ts |
Ports LoadIndicator size checks. |
e2e/playwright/tests/accessibility/list.spec.ts |
Converts List checks with distinct configuration names. |
e2e/playwright/tests/accessibility/htmlEditor.spec.ts |
Ports editor and AI checks using the extended container. |
e2e/playwright/tests/accessibility/gallery.spec.ts |
Converts Gallery option checks. |
e2e/playwright/tests/accessibility/form.spec.ts |
Converts Form and required-field checks. |
e2e/playwright/tests/accessibility/floatingActionButton.spec.ts |
Ports floating-action label and icon checks. |
e2e/playwright/tests/accessibility/filterBuilder.spec.ts |
Converts FilterBuilder ARIA and popup assertions. |
e2e/playwright/tests/accessibility/fileUploader.spec.ts |
Converts FileUploader option configurations. |
e2e/playwright/tests/accessibility/dropDownButton.spec.ts |
Converts split-button and rendering checks. |
e2e/playwright/tests/accessibility/dropDownBox.spec.ts |
Converts DropDownBox rendering and button checks. |
e2e/playwright/tests/accessibility/drawer.spec.ts |
Converts Drawer option checks. |
e2e/playwright/tests/accessibility/dateRangeBox.spec.ts |
Converts DateRangeBox configurations with distinct names. |
e2e/playwright/tests/accessibility/dateBox.spec.ts |
Converts DateBox checks and programmatic opening. |
e2e/playwright/tests/accessibility/dataGrid/templates.spec.ts |
Ports custom row-template checks. |
e2e/playwright/tests/accessibility/dataGrid/status.spec.ts |
Ports status checks with retrying text assertions. |
e2e/playwright/tests/accessibility/dataGrid/scrolling.spec.ts |
Ports infinite and virtual-scrolling checks. |
e2e/playwright/tests/accessibility/dataGrid/editing.spec.ts |
Ports embedded-editor checks across editing modes. |
e2e/playwright/tests/accessibility/contextMenu.spec.ts |
Ports ContextMenu checks, including disabled states. |
e2e/playwright/tests/accessibility/colorBox.spec.ts |
Converts ColorBox checks with distinct configuration names. |
e2e/playwright/tests/accessibility/checkBox.spec.ts |
Converts CheckBox state and information checks. |
e2e/playwright/tests/accessibility/chat.spec.ts |
Converts Chat and tool-call assertions. |
e2e/playwright/tests/accessibility/cardView/search.spec.ts |
Converts highlighted-search checks. |
e2e/playwright/tests/accessibility/cardView/pager.spec.ts |
Converts filtering and paging checks. |
e2e/playwright/tests/accessibility/cardView/noData.spec.ts |
Ports empty CardView checks. |
e2e/playwright/tests/accessibility/cardView/headerFilter.spec.ts |
Ports list, search, and tree filter-popup checks. |
e2e/playwright/tests/accessibility/cardView/filterPanel.spec.ts |
Ports filter-panel and FilterBuilder popup checks. |
e2e/playwright/tests/accessibility/cardView/editing.spec.ts |
Ports card rendering and editing-popup checks. |
e2e/playwright/tests/accessibility/cardView/cover.spec.ts |
Ports card-cover image and alternative-text scenarios. |
e2e/playwright/tests/accessibility/cardView/columnSortable.spec.ts |
Ports column dragging with opacity-based waits. |
e2e/playwright/tests/accessibility/cardView/columnChooser.spec.ts |
Ports column-chooser mode checks. |
e2e/playwright/tests/accessibility/calendar.spec.ts |
Converts Calendar selection-mode checks. |
e2e/playwright/tests/accessibility/buttonGroup.spec.ts |
Converts ButtonGroup option checks. |
e2e/playwright/tests/accessibility/button.spec.ts |
Ports Button labeling and theme-aware axe options. |
e2e/playwright/tests/accessibility/autocomplete.spec.ts |
Converts Autocomplete rendering and button checks. |
e2e/playwright/tests/accessibility/actionSheet.spec.ts |
Converts ActionSheet option checks. |
e2e/playwright/tests/accessibility/accordion.spec.ts |
Ports Accordion expansion interactions. |
e2e/playwright/package.json |
Adds Playwright axe and axe-core dependencies. |
e2e/playwright/models/treeList/index.ts |
Adds a TreeList model extending DataGrid. |
e2e/playwright/models/toolbar/toolbarItem.ts |
Adds a toolbar-item locator wrapper. |
e2e/playwright/models/toolbar/toolbar.ts |
Adds toolbar-item and overflow-menu accessors. |
e2e/playwright/models/toolbar/index.ts |
Exports the Toolbar model. |
e2e/playwright/models/toolbar/dropDownMenu.ts |
Adds a dropdown-menu widget model. |
e2e/playwright/models/textBox.ts |
Adds a TextBox model with input access. |
e2e/playwright/models/menu/index.ts |
Adds visible menu-item locators. |
e2e/playwright/models/internal/focusable.ts |
Adds reusable focus-state assertions. |
e2e/playwright/models/htmlEditor/rootToolbar.ts |
Adds named editor-toolbar item access. |
e2e/playwright/models/htmlEditor/index.ts |
Adds editor content and toolbar accessors. |
e2e/playwright/models/gridCore/index.ts |
Adds shared grid locators and API helpers. |
e2e/playwright/models/gridCore/filter/panel.ts |
Adds filter-panel locators and popup assertions. |
e2e/playwright/models/filterBuilder/index.ts |
Adds FilterBuilder control and popup locators. |
e2e/playwright/models/dateBox/index.ts |
Adds DateBox input and dropdown-button locators. |
e2e/playwright/models/dataGrid/index.ts |
Adds DataGrid locators and editing API helpers. |
e2e/playwright/models/dataGrid/headers/row.ts |
Adds header-row cell access. |
e2e/playwright/models/dataGrid/headers/panelButtons/exportButton.ts |
Adds export-button and menu assertions. |
e2e/playwright/models/dataGrid/headers/panel.ts |
Adds export and apply-filter button access. |
e2e/playwright/models/dataGrid/headers/index.ts |
Adds header-row and filter-row locators. |
e2e/playwright/models/dataGrid/headers/headerFilter.ts |
Adds header-filter popup controls. |
e2e/playwright/models/dataGrid/headers/cell.ts |
Adds header-cell focus and filter-icon access. |
e2e/playwright/models/dataGrid/filter/row.ts |
Adds filter-cell lookup. |
e2e/playwright/models/dataGrid/filter/cell.ts |
Adds filter-editor model construction. |
e2e/playwright/models/dataGrid/editForm.ts |
Adds edit-form and action-button locators. |
e2e/playwright/models/dataGrid/data/row.ts |
Adds row-state assertions and cell access. |
e2e/playwright/models/dataGrid/data/cell.ts |
Adds editing, focus, and modified-cell assertions. |
e2e/playwright/models/dataGrid/columnChooser.ts |
Adds chooser controls and open-state assertions. |
e2e/playwright/models/dataGrid/adaptiveDetailRow.ts |
Adds an adaptive-detail-row locator wrapper. |
e2e/playwright/models/contextMenu/index.ts |
Adds ContextMenu item access and showing. |
e2e/playwright/models/cardView/toolbar.ts |
Adds CardView add-button access. |
e2e/playwright/models/cardView/index.ts |
Adds CardView cards, headers, and toolbar access. |
e2e/playwright/models/cardView/headers/item.ts |
Adds a focusable column-header model. |
e2e/playwright/models/cardView/headers/headers.ts |
Adds indexed column-header lookup. |
e2e/playwright/models/cardView/headerPanel.ts |
Adds header-item and chooser-link access. |
e2e/playwright/models/cardView/headerItem.ts |
Adds header-filter icon access. |
e2e/playwright/models/cardView/card.ts |
Adds card-header and toolbar-item access. |
e2e/playwright/helpers/accessibility/utils.ts |
Adds axe execution, reporting, and viewport setup. |
e2e/playwright/helpers/accessibility/test.ts |
Adds accessibility fixtures and serializable option-matrix tests. |
.github/workflows/testcafe_tests.yml |
Removes TestCafe accessibility jobs and style-change filtering. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.