CI: Always run full test matrix in visual-test-demos workflow - #35020
Open
alexslavr wants to merge 1 commit into
Open
CI: Always run full test matrix in visual-test-demos workflow#35020alexslavr wants to merge 1 commit into
alexslavr wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow changes are internally consistent (no remaining references to removed jobs/outputs) and implement the stated goal of always running the full matrix.
Pull request overview
Updates the Demos Visual Tests GitHub Actions workflow to always execute the full visual-test and lint/TS-check matrix, removing the previous “changed demos only / none” optimization logic so PRs can’t accidentally skip coverage.
Changes:
- Removed PR changed-demo detection (
get-changes) and all “changed-only” branches/jobs (including generated-demos and TestCafe framework “changed” jobs). - Forced
determine-framework-tests-scopeto always outputall, making the workflow consistently run the full matrix on PRs. - Simplified the jQuery matrix construction to always include the dark-theme accessibility cases, and adjusted artifact-merge logic accordingly.
File summaries
| File | Description |
|---|---|
| .github/workflows/visual-tests-demos.yml | Removes change-scoped execution and makes the workflow always run the full test/lint matrix for demos. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.