Map: OSM provider - Add markers and location calculation - #34994
Open
AlisherAmonulloev wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds location resolution and marker rendering to the OSM provider, including OpenLayers overlays, viewport fitting, accessibility, and test coverage.
Changes:
- Adds asynchronous location calculation, caching, and stale-operation handling.
- Implements accessible OSM markers and automatic viewport adjustment.
- Extends OpenLayers mocks, Storybook examples, tests, and localization resources.
Reviewed changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets/mapParts/osmTests.js |
Tests location and marker behavior. |
packages/devextreme/testing/helpers/forMap/openLayersMock.js |
Adds overlay and view-event mocks. |
packages/devextreme/js/ui/map/openlayers.register.js |
Registers OpenLayers overlays. |
packages/devextreme/js/localization/messages/zh.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/zh-tw.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/zh-Hans.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/zh-CN.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/vi.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/uk.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/tr.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/sv.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/sl.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/ru.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/ro.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/pt.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/pt-PT.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/pt-BR.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/pl.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/nl.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/nb.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/lv.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/lt.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/ko.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/ja.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/it.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/hu.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/hi.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/fr.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/fi.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/fa.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/es.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/en.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/el.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/de.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/da.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/cs.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/ca.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/bg.json |
Adds marker ARIA label. |
packages/devextreme/js/localization/messages/ar.json |
Adds marker ARIA label. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.ts |
Implements location resolution and markers. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.utils.ts |
Extends OpenLayers contracts. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.utils.test.ts |
Tests overlay API validation. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.ts |
Implements overlay rendering and fitting. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.openlayers.marker.ts |
Creates marker DOM elements. |
packages/devextreme/js/__internal/ui/map/provider.dynamic.osm.engine.ts |
Defines marker engine contracts. |
apps/react-storybook/stories/map/OSMMap.stories.tsx |
Demonstrates OSM markers. |
apps/react-storybook/.storybook/main.ts |
Serves marker image assets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
arman-boyakhchyan
approved these changes
Sep 1, 2026
AlisherAmonulloev
marked this pull request as ready for review
September 2, 2026 09:36
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Asynchronously loaded content inside HTML markers can outgrow the fallback fit and remain clipped.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 53/53 changed files
- Comments generated: 1
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.