Skip to content

fix(cli): preserve existing binary when installation is skipped - #2994

Open
Bowen-Xue-ac2 wants to merge 3 commits into
DeusData:mainfrom
Bowen-Xue-ac2:fix/skip-binary-preserve-target
Open

Bowen-Xue-ac2 wants to merge 3 commits into
DeusData:mainfrom
Bowen-Xue-ac2:fix/skip-binary-preserve-target

Conversation

@Bowen-Xue-ac2

@Bowen-Xue-ac2 Bowen-Xue-ac2 commented Nov 14, 2026 •

Copy link
Copy Markdown

Summary

Extract the CLI skip_binary fix from #2965, without the cache diagnostics or RSS changes.

Validation

  • Hosted CI: lint, Windows, macOS, Ubuntu ARM and TSan passed. Ubuntu x86 failed on two daemon tests and a CLI timeout. Similar failures predate this patch and are being investigated in test: keep copied-image daemon tests CPU-independent under sanitizers #2987; the cause of this run has not been confirmed.
  • Debian 13.6, ASan/UBSan: both regression tests passed with the fix and failed with the original cli.c. The full CLI suite had 405 passed, 9 failed and 1 skipped; all nine failures also occurred in the control run.
  • The local executor blocked eight Unix-socket fixtures; one symlink assertion failed in both versions. Local results do not independently validate native macOS signing or Windows behavior.
    Checklist
  • Every commit is signed off.
  • Full local test suite passes.
  • Hosted CI lint passes.
  • New behavior has reproduce-first regression coverage.

Keep config-only installs from re-enabling binary replacement, and make
macOS signing respect the same skip-binary policy.

Cover existing and absent targets, content and metadata preservation,
agent configuration updates, and approved replacement controls. Add a
real-IPC existing-target no-drain case alongside the absent-target case.

Signed-off-by: BowenX <318502935+Bowen-Xue-ac2@users.noreply.github.com>
(cherry picked from commit af0205d)
Pin the managed mise install path without an explicit skip flag and verify completed installs leave no sibling stage files. Coverage follows the review suggestions in DeusData#2965 and the managed-binary scenario in DeusData#2990.

Signed-off-by: BowenX <318502935+Bowen-Xue-ac2@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@Bowen-Xue-ac2
Bowen-Xue-ac2 marked this pull request as ready for review November 16, 2026 01:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant