Repository navigation
fix(cli): preserve existing binary when installation is skipped - #2994
Open
Bowen-Xue-ac2 wants to merge 3 commits into
Open
Bowen-Xue-ac2 wants to merge 3 commits into
Bowen-Xue-ac2 wants to merge 3 commits into
Conversation
Keep config-only installs from re-enabling binary replacement, and make macOS signing respect the same skip-binary policy. Cover existing and absent targets, content and metadata preservation, agent configuration updates, and approved replacement controls. Add a real-IPC existing-target no-drain case alongside the absent-target case. Signed-off-by: BowenX <318502935+Bowen-Xue-ac2@users.noreply.github.com> (cherry picked from commit af0205d)
Pin the managed mise install path without an explicit skip flag and verify completed installs leave no sibling stage files. Coverage follows the review suggestions in DeusData#2965 and the managed-binary scenario in DeusData#2990. Signed-off-by: BowenX <318502935+Bowen-Xue-ac2@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Bowen-Xue-ac2
marked this pull request as ready for review
November 16, 2026 01:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the CLI skip_binary fix from #2965, without the cache diagnostics or RSS changes.
Related to fix(cli): keep the existing binary under install --skip-binary #2990 and the review discussion on Fix/2955 cache path diagnostic #2965; this PR does not supersede fix(cli): keep the existing binary under install --skip-binary #2990.
Validation
Checklist