Repository navigation
Conversation
Signed-off-by: DavidHLP <lysf15520112973@163.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
Signed-off-by: DavidHLP <lysf15520112973@163.com>
Signed-off-by: DavidHLP <lysf15520112973@163.com>
|
I wanted to leave a consolidated validation note for the maintainers at head The latest PR workflow completed successfully: 34 jobs passed and 5 were skipped by the workflow. DCO also passed. This includes native Windows package-wrapper tests, Windows regression guards, the full Windows CLANG64 C test job, all three platform smoke jobs, and the remaining macOS Intel test job. Skipped jobs are not counted as successful validation. For #2877, the Go verifier now waits for the actual Two follow-up CI failures led to focused fixes: the watchdog test handles Windows CRLF correctly, and Windows worker-log polling preserves the last readable trace and retries access/sharing errors (Win32 5/32), retaining the error in diagnostics. Other permission errors and CLI stderr failures still propagate. Both failures were reproduced locally before their fixes; the current native Windows wrapper and guard jobs pass. An earlier full Windows C run exited with There are deliberate behavior limits to consider during review: standalone wrapper invocations need caller supervision if a verifier actually hangs, and another wrapper can exhaust the existing 45-second publication-lock wait while verification is still running. Lock policy and cache/publication/recovery semantics are unchanged. My full local C/lint runs had the environment/tooling limitations recorded in the PR description; the successful remote workflow is separate evidence. I am leaving the PR as a draft for maintainer judgment on the scope and these tradeoffs. |
Signed-off-by: DavidHLP <lysf15520112973@163.com>
What does this PR do?
Fixes #2877.
The Go wrapper currently runs each candidate's
--versionunder a 15-second context deadline. A correctly functioning candidate can therefore fail verification on a slow runner. Verification now waits for the actual process result and preserves executable-start and nonzero-exit errors.Add a command-construction seam and real Go helper-process regression coverage. A handshake holds the candidate until explicitly released; the test also rejects a verification context with a deadline, so the old 15-second implementation fails immediately without sleeping past that deadline. Both successful and nonzero child exits, plus a missing executable, are covered.
The existing Go wrapper smoke invocation runs under a separate ten-minute guard. Exceeding that outer bound reports a HANG in the download/verification/execution path, kills the process tree, reaps the wrapper, and returns 124; it does not assert a verifier performance threshold. The existing smoke result assertion is unchanged. Guard tests cover real exit codes, startup failure, deterministic injected expiry after a real child handshake, and Unix/Windows cleanup dispatch; they run through the existing package-wrapper CI entry point.
No cache format, checksum validation, publication/recovery logic, or lock-owner reclamation rules change. Standalone wrapper invocations intentionally wait for the verifier's result; an actually stuck candidate needs caller supervision/interruption. The existing 45-second concurrent lock wait can still expire while another process verifies a slow candidate.
Validation
bash scripts/ci/test-package-wrappers.sh: Go suite; watchdog 4 tests; npm 20 passed / 3 Windows-only PowerShell tests skipped on Linux; PyPI 45 passed.go test -race ./...andgo vet ./...inpkg/go.git diff --check.scripts/smoke-wrappers.sh ... gowith a synthetic C executable/archive, required sidecars and checksum manifest served on loopback. This nested checkout required process-localGOFLAGS=-buildvcs=falsebecause Go attempted VCS stamping from the parent Projects directory; no repository setting changed. This is not a real release-artifact smoke.scripts/test.shreached the existing venue-parity contract, which invokesbash scripts/ci/generate-sbom.py --help; Python'simport datetimelaunched ImageMagickimportand blocked. Terminated only this test's isolated process group. The full C suite did not run.scripts/lint.sh; cppcheck is missing, and clang-tidy reports diagnostics in untouched C sources.1b7926d: native Windows and Ubuntu package-wrapper jobs; Windows, Linux and macOS PR smoke jobs. The Windows watchdog test now reads the handshake with universal-newline handling and emits raw CRLF on every host; this reproduces the initial Windows failure on Linux before the reader fix. The Windows guards failure on1b7926dwas reproduced locally by injecting the logged Win32 access-denied error into the actual trace reader. Follow-upa9f98cfcmakes polling preserve the last readable worker trace and retry Win32 deletion/sharing errors (5/32), with the error retained in diagnostics. CLI stderr failures and other permission errors still propagate. Two focused regression tests are wired into the existing Windows guards entry point and pass locally. The native Windows guards job now passes ona9f98cfc: https://github.com/DeusData/codebase-memory-mcp/actions/runs/42830764926/job/129887639759 . The Windows full C test job also failed:extraction_inheritance,java_lsp_coverage, anddoc_links_mdexited with3221225477(0xC0000005, access violation), without completion summaries. Failing full-test job. The failing C tests, C sources and their workflow are unchanged in this PR; base-revision failure has not been independently reproduced. Local investigation: the three C suites pass under Linux ASan/UBSan (321 tests). Their three original crash-site cases also pass as separate parallel processes in full Windows-target ASan/UBSan test runners under Wine, using both LLVM 23 and CI-matching LLVM 22.1.8. Wine reports sanitizer interception warnings and is diagnostic evidence only. No C fix is claimed without a local reproduction. The full native Windows job ona9f98cfcis still running: https://github.com/DeusData/codebase-memory-mcp/actions/runs/42830764926/job/129887704227 . A native crash-diagnostic workflow was prepared only on the personal fork branchdebug/pr-2946-windows-crash, but GitHub rejects dispatch with HTTP 422, Actions disabled, despite permissions reporting enabled. Full CI and maintainer review remain pending.Checklist
git commit -s)make -f Makefile.cbm test) — full C suite not completed; focused wrapper entry passedmake -f Makefile.cbm lint-ci) — environment/tooling limitations above