Conversation
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
CLI_USAGE described outer --json but did not mention tool-level --format json. Add a help-only pointer that tools which accept format support --format tree|json, and distinguish payload JSON from the full MCP envelope. No new flags, env vars, or output-default changes. Fixes DeusData#2102 Signed-off-by: Lowpower <3133734+Lowpower@users.noreply.github.com>
Signed-off-by: Lowpower <3133734+Lowpower@users.noreply.github.com>
Lowpower
force-pushed
the
cursor/cli-help-format-json-cb65
branch
from
September 17, 2026 05:40
a1d11e7 to
b74c035
Compare
The DeusData#1828 fast-fail test forks a real daemon host and waits for the injected publication ENOSPC. Production MCP clients use a 30s startup budget, but under MSan the child still has to finish claim, mem_init, and host_state_prepare before listen. That path can exceed 30s, so the client reports "active or starting" and the suite fails even though the help-text change never touched this code. Keep proving fast-fail by the recorded ENOSPC cause and a single spawn, not by wall-clock. Widen only this test's wait. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Lowpower <Lowpower@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/cli-help-format-json-cb65
branch
from
September 18, 2026 03:30
b52df4b to
ca34611
Compare
search_code format=json is JSON only after a complete scan. A fail-closed grep (supervision / contained-command) returns an error string, so yyjson_read is NULL — "doc is NULL" on macos-15-intel while the same SHA passed macos-14. The help-text change never touched this path. Keep the 601-hit bound/expand assertions. One retry absorbs the host flake; a second miss dumps inner instead of an opaque NULL. Co-authored-by: Lowpower <Lowpower@users.noreply.github.com> Signed-off-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Help-only discoverability fix for #2102 (direction c only).
Top-level
cli --helpalready described outer--json(the raw MCP result envelope) but did not mention that tools which acceptformatsupport--format tree|json. Habitual CLI users look atcli --helpfirst; per-tool--helpalready documented--format.This PR adds two lines to
CLI_USAGE:--format tree|json(default: tree).--format jsonprints payload JSON; outer--jsonprints the full MCP envelope.No session-wide
--formatflag, noCBM_CLI_FORMATenv var, and no change to output defaults.CBM_CLI_USAGElives insrc/cli/cli.hsotests/test_cli.ccan assert on the same stringrun_cli()prints.Checklist
git commit -s) — required, CI rejects unsigned commitsscripts/test.sh --suites cli— includingcli_usage_points_to_tool_format_json_issue2102)Fixes #2102