Skip to content

fix(ui): load all paginated projects (#1812) - #1819

Open
rarepops wants to merge 1 commit into
DeusData:mainfrom
rarepops:fix/ui-project-pagination-1812
Open

fix(ui): load all paginated projects (#1812)#1819
rarepops wants to merge 1 commit into
DeusData:mainfrom
rarepops:fix/ui-project-pagination-1812

Conversation

@rarepops

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #1812.

  • follows list_projects pagination until has_more is false
  • publishes the complete project list before schema hydration finishes
  • caps schema hydration at four concurrent requests
  • rejects non-advancing pagination metadata instead of looping indefinitely
  • adds regressions for a 51-project result and bounded schema concurrency

Validation

  • cd graph-ui && npm test (41 passed)
  • cd graph-ui && npm run build
  • git diff --check

Checklist

  • Every commit is signed off (git commit -s)
  • Tests pass locally (make -f Makefile.cbm test) (full native suite not run; focused UI suite passed)
  • Lint passes (make -f Makefile.cbm lint-ci) (not run locally)
  • New behavior is covered by a reproduce-first test

@rarepops
rarepops requested a review from DeusData as a code owner August 24, 2026 17:43
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@rarepops rarepops changed the title fix(ui): load all paginated projects fix(ui): load all paginated projects (#1812) Aug 24, 2026
Follow list_projects pagination metadata so the management UI does not stop at 50 projects. Publish the complete list before schema hydration and cap schema lookups at four concurrent requests.

Signed-off-by: Rares Popa <2606875+rarepops@users.noreply.github.com>
@rarepops
rarepops force-pushed the fix/ui-project-pagination-1812 branch from bda9282 to f7bccab Compare August 24, 2026 20:00
@rarepops

Copy link
Copy Markdown
Contributor Author

CI note: the fresh run's test-windows-guards failure is outside this PR's two TypeScript files and appears to cascade from guard setup state.

The raw job log shows:

  1. test_non_ascii_path.py first reports SETUP FAIL: ASCII baseline did not index after its Unicode relocation check passed.
  2. The next daemon lifecycle guard then finds an active daemon with a different cache/build and cannot start its isolated daemon.
  3. The daemon stability guard fails for the same active-cache/build mismatch.
  4. Both regular Windows shards pass, as do macOS TSan (the prior unrelated failure), Linux TSan, UI build, lint, DCO, and security checks.

The branch is current with main, mergeable, and changes only:

  • graph-ui/src/hooks/useProjects.ts
  • graph-ui/src/hooks/useProjects.test.tsx

I do not have permission to rerun repository jobs. A maintainer rerun of test-windows-guards should distinguish this guard-state cascade without adding unrelated churn to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Management UI only displays the first 50 projects and ignores list_projects.has_more

1 participant