Skip to content

fix(ui): allow graph schema through UI RPC #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
astandrik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): allow graph schema through UI RPC #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ui/http_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,7 +1721,8 @@ static bool rpc_is_allowed_for_ui(const char *body, size_t body_len) {
const char *name_text = yyjson_is_str(name) ? yyjson_get_str(name) : NULL;
bool allowed =
method_text && strcmp(method_text, "tools/call") == 0 && name_text &&
(strcmp(name_text, "list_projects") == 0 || strcmp(name_text, "get_code_snippet") == 0);
(strcmp(name_text, "list_projects") == 0 || strcmp(name_text, "get_code_snippet") == 0 ||
strcmp(name_text, "get_graph_schema") == 0);
yyjson_doc_free(document);
return allowed;
}
Expand Down
35 changes: 22 additions & 13 deletions tests/test_httpd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,22 +1086,31 @@ TEST(ui_server_mutations_require_json_content_type) {
TEST(ui_server_rpc_allows_only_ui_read_tools) {
th_server_t ts;
ASSERT_EQ(th_server_start(&ts), 0);
const char *body = "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"tools/call\","
"\"params\":{\"name\":\"list_projects\",\"arguments\":{}}}";
char req[1024];
snprintf(req, sizeof(req),
"POST /rpc HTTP/1.1\r\n"
"Content-Type: application/json\r\n"
"Content-Length: %d\r\n\r\n%s",
(int)strlen(body), body);
char resp[8192];
int n = th_http(cbm_http_server_port(ts.srv), req, resp, sizeof(resp));
ASSERT_GT(n, 0);
ASSERT_EQ(th_status(resp), 200);
ASSERT_NOT_NULL(strstr(resp, "\"jsonrpc\""));
int n;

static const char *allowed_tools[] = {"list_projects", "get_code_snippet", "get_graph_schema"};
for (size_t i = 0; i < sizeof(allowed_tools) / sizeof(allowed_tools[0]); i++) {
char allowed_body[512];
snprintf(allowed_body, sizeof(allowed_body),
"{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"tools/call\","
"\"params\":{\"name\":\"%s\",\"arguments\":{}}}",
allowed_tools[i]);
snprintf(req, sizeof(req),
"POST /rpc HTTP/1.1\r\n"
"Content-Type: application/json\r\n"
"Content-Length: %zu\r\n\r\n%s",
strlen(allowed_body), allowed_body);
n = th_http(cbm_http_server_port(ts.srv), req, resp, sizeof(resp));
ASSERT_GT(n, 0);
ASSERT_EQ(th_status(resp), 200);
ASSERT_NOT_NULL(strstr(resp, "\"jsonrpc\""));
ASSERT_NULL(strstr(resp, "UI RPC method is not allowed"));
}

static const char *blocked_tools[] = {"delete_project", "manage_adr", "ingest_traces",
"index_repository"};
static const char *blocked_tools[] = {"search_graph", "delete_project", "manage_adr",
"ingest_traces", "index_repository"};
for (size_t i = 0; i < sizeof(blocked_tools) / sizeof(blocked_tools[0]); i++) {
char blocked_body[512];
snprintf(blocked_body, sizeof(blocked_body),
Expand Down
Loading