fix(pipeline): preserve dotted TypeScript import basenames - #1811
fix(pipeline): preserve dotted TypeScript import basenames#1811pcristin wants to merge 1 commit into
Conversation
Signed-off-by: Pcristin <xxxokzxxx@protonmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
CI triage: the only substantive red job is This PR changes only FQN/import resolution and its regression tests; it does not touch daemon or Windows-guard code. The same cold-storm timeout occurred on the unrelated PR #1245 workflow run, while surrounding runs of this guard passed, so this matches an I tried to rerun only the failed jobs, but GitHub rejected it because contributors do not have repository Actions rerun permission. Could you @DeusData rerun the failed jobs? I have deliberately not added an unrelated code change or empty commit just to retrigger CI. |
|
Thank you for the careful CI attribution. I checked the diff and current main: this PR is limited to FQN and import resolution plus its regression tests, while the red job is the Windows daemon guard. That failure is outside this change path and matches the existing startup-flake family you linked. You are also correct that contributors cannot rerun repository jobs. This should be rerun from the maintainer side, and there is no need to create an unrelated commit. Thank you for documenting the evidence instead of treating the red aggregate as proof against the patch. |
What does this PR do?
Preserve extensionless dotted JavaScript/TypeScript module basenames such as
featureX.engineduring relative-import resolution.final dot suffix as an extension.
relative resolver has normalized the path.
helperBandSomeTypeIMPORTSedges both targetfeatureX.engine.ts.Refs #1682.
Verification
make -f Makefile.cbm test-focused TEST_SUITES='fqn edge_imports'— 143 passedmake -f Makefile.cbm test-par— 7,577 passed, 0 failed, 8 skipped across 139 suitesgit diff --checkclang-format --dry-run --WerrorThe repository-wide
lint-cibaseline is not clean in untouched files: cppcheckreports existing style findings in
src/store/store.candsrc/cypher/cypher.c,and the formatter reports existing findings in
src/mcp/mcp.candsrc/pipeline/pipeline_incremental.c. No unrelated lint cleanup is included here.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)