fix(mcp): attribute post-publish failures to artifact export (#1665) - #1789
Open
umi008 wants to merge 1 commit into
Open
fix(mcp): attribute post-publish failures to artifact export (#1665)#1789umi008 wants to merge 1 commit into
umi008 wants to merge 1 commit into
Conversation
A failed persistence artifact export after a successful publish reported status error with a hint blaming repo_path: 'Pipeline failed. Check repo_path exists and contains source files.' On a read-only checkout with --persistence true, the graph database was published fine — only the team-sharing artifact could not be written — and the hint pointed the reader at the wrong cause. The pipeline now snapshots the artifact export error of the run it just executed (not the process-global one, which may describe a previous run). index_repository uses that snapshot to name the real failure — the artifact directory, the export detail and the remedies (writable checkout or --persistence false) — while every other failure keeps the existing hint byte-for-byte. The fail-hard semantics are unchanged. Fixes DeusData#1665 Signed-off-by: Ulises Millan Guerrero <ulises.millanguerrero@gmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With
--persistence trueon a read-only repository,index_repositoryreportedstatus: "error"with the hint "Pipeline failed. Check repo_path exists and contains source files" — blaming the repository for a failure that is actually the post-publish team-sharing artifact export (.codebase-memory/cannot be written inside a read-only checkout). The graph database itself published fine.The pipeline now snapshots the artifact export error of the run it just executed (a per-pipeline buffer, not the process-global export error which can describe a previous run).
index_repositoryconsults that snapshot on failure and names the real cause: the artifact export, the error detail, and the remedies (writable checkout or--persistence false). Every other failure path keeps the existing hint byte-for-byte.The fail-hard semantics are unchanged: a failed persistence export still makes the run fail, which is the in-tree documented decision (
export_after_publish, "intentionally fails the run"). This change only makes an already-failing run report the truth — the issue-1466-era misleadingrepo_pathhint is what hid the cause.Verified with a reproduce-first pipeline test: an artifact directory blocked (
.codebase-memoryas a file), fixture indexed, assertsrc != 0,cbm_pipeline_export_error()non-empty and naming the artifact phase, the DB still published, and a clean re-run leaving the snapshot empty.Checklist
git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)