Skip to content

fix(mcp): flag source drift in get_code_snippet and search_code (#1750) - #1788

Open
umi008 wants to merge 1 commit into
DeusData:mainfrom
umi008:fix/issue-1750-stale-ast-coords
Open

fix(mcp): flag source drift in get_code_snippet and search_code (#1750)#1788
umi008 wants to merge 1 commit into
DeusData:mainfrom
umi008:fix/issue-1750-stale-ast-coords

Conversation

@umi008

@umi008 umi008 commented Aug 21, 2026

Copy link
Copy Markdown

What does this PR do?

get_code_snippet and search_code sliced the live file on disk using line coordinates recorded at index time. After the file was edited without re-indexing those ranges are stale, and the tools returned shifted source text — a grep hit misattributed to an adjacent function, or a snippet of the wrong symbol — presented as though it were current source.

Both tools now consult the same freshness oracle check_index_coverage already exposes. When the recorded metadata no longer matches the file on disk (metadata_changed/missing), they skip the stale live slice and report source_drift: true plus the freshness state instead. The healthy path (metadata_match) is byte-identical to before; re-indexing remains the remedy.

Tested with two reproduce-first regression tests: a snippet request and a full-mode search after a file is modified on disk (asserting source_drift and no stale text), plus the unchanged clean-metadata path.

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test)
  • Lint passes (make -f Makefile.cbm lint-ci)
  • New behavior is covered by a test (reproduce-first for bug fixes)

The snippet and full-mode search tools slice the live file on disk using
line coordinates recorded at index time. After the file is edited without
re-indexing, those ranges are stale: the tools returned shifted source
text, or a grep hit attributed to an adjacent function, with no signal
that the answer was drifting (everything after a small edit looked like
current source).

Both tools now consult the same freshness oracle check_index_coverage
already exposes. When the file no longer matches the recorded metadata
(metadata_changed/missing) they skip the stale live slice and report
source_drift/freshness instead; the healthy path (metadata_match) is
byte-identical to before. No index-format change: the recorded metadata
is unchanged, only the read tools consult it.

Fixes DeusData#1750

Signed-off-by: Ulises Millan Guerrero <ulises.millanguerrero@gmail.com>
@umi008
umi008 requested a review from DeusData as a code owner August 21, 2026 19:57
@github-actions

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant