Repository navigation
Description
Version
v0.12.1 release binary, Linux (x64). The code path is unchanged on main @ cdfdf26.
What happened, and what did you expect?
On the parallel resolver (more than 50 files), a Rust method call whose receiver the LSP leaves untyped goes through try_field_type_hint (src/pipeline/pass_parallel.c). The hint capitalises the receiver's variable name and binds the candidate whose owning segment equals it, at 0.85. #1936 (for #1927) narrowed that from a substring to an owning-segment match, and Go is excluded (F-G9), but Rust still runs it. Segment equality still fires whenever a variable is named after an unrelated project type. The receiver's declared type is never read.
Expected: a variable name alone yields no CALLS edge, least of all at 0.85. source: &Series calls Series::key; source: extcrate::Bar calls the crate's Bar::key.
Reproduction
Cargo.toml ([dependencies] extcrate = "1", never built), src/lib.rs declaring the modules below, plus 55 one-line src/padN.rs files (pub fn padN() -> u32 { N }) to cross MIN_FILES_FOR_PARALLEL.
// src/series.rs
pub enum Series {
Bars(u32),
}
impl Series {
pub fn key(&self) -> u32 {
match self {
Self::Bars(n) => *n,
}
}
}// src/source.rs
pub struct Source(pub u32);
impl Source {
pub fn key(&self) -> u32 {
self.0
}
}// src/user.rs
use crate::series::Series;
use extcrate::Bar;
/// Declared `&Series`: calls Series::key. Must not bind Source::key.
pub fn declared_project_type(source: &Series) -> u32 {
source.key()
}
/// Declared external `Bar`: calls extcrate's Bar::key. Must not bind Source::key.
pub fn declared_external_type(source: Bar) -> u32 {
source.key()
}codebase-memory-mcp cli index_repository '{"repo_path":"<repro>"}'
codebase-memory-mcp cli query_graph '{"project":"<p>","query":"MATCH (a)-[r:CALLS]->(b) WHERE b.name = \"key\" RETURN a.name, b.qualified_name, r.strategy, r.confidence"}'
| caller | parallel (57 files) | sequential (same repo without the pad files) |
|---|---|---|
declared_project_type |
src.source.Source.key, field_type_hint, 0.85 |
src.series.Series.key, suffix_match, 0.55 |
declared_external_type |
src.source.Source.key, field_type_hint, 0.85 |
src.series.Series.key, suffix_match, 0.55 |
Both parallel edges are wrong, and the hint turns a 0.55 guess into a 0.85 one. The two resolvers also diverge, which is what F-G9 removed for Go.
Two side notes. Neither edge is lsp_* in either resolver: the LSP leaves source: &Series untyped although Series comes in through use crate::series::Series. The sequential edge for declared_external_type is the external-receiver fallback, which I'm filing separately.
Possible fix: exclude Rust from try_field_type_hint as Go is.
Activity