feat(learning): roadmap completion screen with share post and next-roadmap flow - #92
Open
OthmaneZ05 wants to merge 9 commits into
Open
feat(learning): roadmap completion screen with share post and next-roadmap flow#92OthmaneZ05 wants to merge 9 commits into
OthmaneZ05 wants to merge 9 commits into
Conversation
# Conflicts: # frontend/src/shared/types/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Finishing a roadmap now opens a completion screen over the canvas instead of a plain toast. It celebrates the run with facts read off the real play-through and turns it into something the learner can carry out of the app:
startedAtwhen a play-through's entry is created (backend +docs/learning-api.mdupdated).deriveTopologysource as the briefing page, no parallel derivation.ClipboardItem, EN/FR.LearningExitintent mirroringLearningIntent, consumed one-shot byProjectsPage. Falls back to "All roadmaps" plus a catalogue-complete note when nothing is left.useLearningPlayer(fresh completion = the verdict that turned the last missing step green; deduplicated so re-validating a complete roadmap never reopens the screen). The step toast is suppressed/consumed when the celebration opens.Types of Changes
Verification & Testing
Automated Checks
npm run lintsuccessfully with no errorsnpm run buildsuccessfully with no compilation errorsnpm testsuccessfully (all tests pass)Backend:
npm run buildclean, 448/448 tests pass. Frontend:npm run buildclean, lint clean (0 errors, 6 pre-existing warnings unrelated to this change), 299 tests pass — 2 initially timed out under parallel load (CanvasPagerename test,PostgresModaltabs test, both unrelated to this feature) and passed cleanly re-run in isolation.Manual Verification
Playwright recipe against the dev server with every backend call mocked via
page.route()(progress = all steps but the last passed), run in EN and FR:started/finishedfrom the store), steps recap, skills chips, and the share image card preview.ClipboardItem.Checklist