Skip to content

ci: the macOS PTY run is its own job, not a required check - #132

Merged
Derrors merged 1 commit into
mainfrom
ci/macos-terminal-not-required
Nov 15, 2026
Merged

Derrors merged 1 commit into
mainfrom
ci/macos-terminal-not-required

Conversation

@Derrors

@Derrors Derrors commented Nov 15, 2026

Copy link
Copy Markdown
Owner

What and why

The required CI / macos check fails often on its last step, "Terminal menus (PTY)". In the last 40 CI runs, macos failed 15 times:

  • 11 at the PTY step. The same script never failed on Linux.
  • 3 at clippy. These failed on Linux too; they were real.
  • 1 in cargo test (update/transaction/tests.rs:288, a one-off).

tests/terminal.py simulates typing through timing between two processes, which a busy macOS runner breaks. #131 fixes the two cases that failed, but the script stays timing-based. A stall shouldn't block a merge, and it shouldn't hide the macOS compile check either.

  • The PTY step moves out of macos into a new job, macos-terminal. It builds only iphone-control and its test binary, then runs the same script. The new job is not in the main ruleset's required checks (rust, macos, msrv, secrets, packages), so it reports on every PR without blocking. No ruleset change is needed.
  • macos keeps clippy and cargo test --workspace on macOS and stays required.
  • On Linux, the PTY script stays in rust and stays required.
  • CONTRIBUTING's CI paragraph says the macOS PTY run is reported but not required.

Cost: one more macOS runner per PR. It builds less than macos and has its own cache key.

Tests

1. Unit tests

  • No Rust changes. The workflow parses (jobs: changes, rust, macos, macos-terminal, packages, msrv, secrets). This PR's own CI run is the real check.
  • The new job's build commands, cargo build -p iphone-control --all-features --locked and cargo test -p iphone-control --all-features --locked --no-run, ran locally on macOS. tests/terminal.py --test-dir target/debug/deps found pty_menu's binary and passed.
  • No test removed or loosened. The same script runs on both platforms; only the macOS run stops being a gate.

2–4. Real-device regression and proof

  • Not applicable: CI configuration and docs only.

Checklist

  • No changelog line: CI only
  • No private data

🤖 Generated with Claude Code

The terminal-menu PTY script simulates typing through timing between
two processes, and busy macOS runners stall often enough to fail it
(11 of the last 15 `macos` failures). It moves out of `macos` into
`macos-terminal`, which runs and reports as before but isn't in the
ruleset's required checks. `macos` keeps clippy and the unit tests as
the gate; the same script stays required on Linux in `rust`.
CONTRIBUTING says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Derrors
Derrors merged commit 46fbb41 into main Nov 15, 2026
7 checks passed
@Derrors
Derrors deleted the ci/macos-terminal-not-required branch November 16, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant