Repository navigation
ci: the macOS PTY run is its own job, not a required check - #132
Merged
Merged
Conversation
The terminal-menu PTY script simulates typing through timing between two processes, and busy macOS runners stall often enough to fail it (11 of the last 15 `macos` failures). It moves out of `macos` into `macos-terminal`, which runs and reports as before but isn't in the ruleset's required checks. `macos` keeps clippy and the unit tests as the gate; the same script stays required on Linux in `rust`. CONTRIBUTING says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The required
CI / macoscheck fails often on its last step, "Terminal menus (PTY)". In the last 40 CI runs,macosfailed 15 times:cargo test(update/transaction/tests.rs:288, a one-off).tests/terminal.pysimulates typing through timing between two processes, which a busy macOS runner breaks. #131 fixes the two cases that failed, but the script stays timing-based. A stall shouldn't block a merge, and it shouldn't hide the macOS compile check either.macosinto a new job,macos-terminal. It builds onlyiphone-controland its test binary, then runs the same script. The new job is not in themainruleset's required checks (rust,macos,msrv,secrets,packages), so it reports on every PR without blocking. No ruleset change is needed.macoskeeps clippy andcargo test --workspaceon macOS and stays required.rustand stays required.Cost: one more macOS runner per PR. It builds less than
macosand has its own cache key.Tests
1. Unit tests
changes,rust,macos,macos-terminal,packages,msrv,secrets). This PR's own CI run is the real check.cargo build -p iphone-control --all-features --lockedandcargo test -p iphone-control --all-features --locked --no-run, ran locally on macOS.tests/terminal.py --test-dir target/debug/depsfoundpty_menu's binary and passed.2–4. Real-device regression and proof
Checklist
🤖 Generated with Claude Code