Add GitHub product API settings#15303
Open
tungyhardDevOps wants to merge 2 commits into
Open
Conversation
Author
|
hello @Maffooch @blakeaowens could you please give this a review? thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #8819.
This PR allows API clients to associate a GitHub project and an existing GitHub configuration while creating a product through
POST /api/v2/products/.The product serializer now accepts the optional, write-only
github_projectandgithub_configurationfields:After the product is created, the serializer creates the existing
GITHUB_PKeyrelation when either GitHub field was supplied:Test results
Added
unittests/test_product_github_api.pycovering:The focused Django tests passed:
Ruff 0.15.21 passed for both changed files.
EXE002was excluded locally because Docker Desktop marks Windows bind-mounted files as executable; Git records both files with normal100644modes.Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.
dev.dev.bugfixbranch.