Extend user serializer validation to identity and permission fields#15191
Open
devGregA wants to merge 1 commit into
Open
Extend user serializer validation to identity and permission fields#15191devGregA wants to merge 1 commit into
devGregA wants to merge 1 commit into
Conversation
devGregA
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
July 8, 2026 20:20
94d44e5 to
d24d456
Compare
Contributor
Author
|
/test all |
devGregA
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
July 9, 2026 01:05
d24d456 to
dc5fc07
Compare
devGregA
changed the title
devGregA
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
July 9, 2026 04:00
dc5fc07 to
1b9f54f
Compare
github-actions
Bot
added
settings_changes
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
valentijnscholten
added a commit
that referenced
this pull request
Jul 21, 2026
v3 security-parity review of three open v2 hardening PRs (#15300, #15296, #15191): #15300 IMMUNE (v3 locations read-only, no reference- write surface); #15296 IMMUNE (configuration_permissions not on the v3 user write surface); #15191 identity half was a REAL GAP now fixed. Gap: get_authorized_users returns co-members, so a non-superuser with view_user+change_user could PATCH/PUT a visible co-member's email or username -> account takeover via password reset. Adds _enforce_identity_field_rules (mirrors UserSerializer.validate()): superuser unrestricted, self-edit allowed, email/username change to another account -> 400; create is a no-op. Wired into PATCH and PUT after the superuser/staff gate; deny-by-default sweep unchanged. +6 tests. (API_V3_PLAN.md also carries the examples-refresh §12 row committed next.)
Only superusers may change the username or email of another account. Prevents account takeover via changing a victim's email then triggering password reset. Users may still edit their own identity fields. Config-permission guards already landed via DefectDojo#15296; this adds the remaining identity-field guard PR DefectDojo#15191 intended. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Maffooch
force-pushed
the
devgrega/user-serializer-field-guards
branch
from
July 23, 2026 03:26
1b9f54f to
30eae24
Compare
github-actions
Bot
removed
settings_changes
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Maffooch
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
UserSerializer.validate()to cover theemailandusernamefields and theconfiguration_permissionsassignment, applying the same kind of validation it already performs for theis_superuserandis_stafffields. This keeps the serializer's validation consistent across its sensitive fields: only superusers may change another account's identity fields or an account's configuration permissions.Users editing their own non-sensitive fields are unaffected, and superusers retain full control.
Test results
Adds
unittests/test_apiv2_user_identity_authz.pycovering the identity-field and configuration-permission validation paths.