fix(api): validate side-effect tool input types - #133
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Authenticated callers could crash the API process by sending malformed JSON to side-effect tools. A concrete repro was
POST /v1/tools/webhook-sendwithmethod: null: after credit deduction, the handler calledmethod.toUpperCase()outside its try/catch, closing the socket and taking down the Node process. The sibling email side-effect routes had the same class of unchecked string dereferences onto/subject.Root cause
webhook-send,email-send, andsend-emailtrusted TypeScript casts for untrusted request-body fields. Non-string JSON values passed the truthiness checks and then hit string methods directly.Fix
methodvalues with400 invalid_requestbefore.toUpperCase().Validation
npm run buildwith local test env: passed.node tests/critical-regressions.test.mjs: 6 passed, 0 failed.webhook-sendproducedUND_ERR_SOCKET, then/healthreturnedECONNREFUSED.webhook-sendreturned400 invalid_request(method must be a string), then/healthreturned200 { ok: true }.email-sendandsend-emailrequests returned400 invalid_request;/healthremained 200.node --loader ts-node/esm tests/ssrf.test.js: passed.