Implement orientation forwarding#402
Merged
MaatheusGois merged 4 commits intoJul 13, 2026
Merged
Conversation
DominatorVbN
force-pushed
the
feature/orientation_forwarding
branch
from
dfbffe1 to
3940c8e
Compare
Overlay windows (CustomWindow, MeasurementWindow) now mirror the host app's orientation constraints instead of rotating independently. - Add OrientationForwardingNavigationController: delegates shouldAutorotate, supportedInterfaceOrientations, preferredInterfaceOrientationForPresentation, and prefersInterfaceOrientationLocked (iOS 26+) to the app's top VC - Swizzle UIWindowScene.requestGeometryUpdate (iOS 16+) to trigger setNeedsUpdateOfSupportedInterfaceOrientations on DebugSwift windows - Wire both overlay windows to use OrientationForwardingNavigationController - Add orientationForwarding to DebugSwiftSwizzleFeature for opt-out support
DominatorVbN
force-pushed
the
feature/orientation_forwarding
branch
from
3940c8e to
be1abee
Compare
Member
|
@DominatorVbN can u review the CI? |
Contributor
Author
|
@MaatheusGois Please help adding run-ci label to check my fix against CI. |
Contributor
Author
|
There was another test failure missed by my previous commit, in FeatureBaseTests::testDebugSwiftSwizzleFeature_allCases. My latest commit fixes that, i have verified running the the test just in case, should resolve the CI pipeline now. |
ExampleTests.xctest: Coverage: 97.14
Generated by 🚫 Danger Swift against 9636c77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new
OrientationForwardingNavigationControllerto ensure that custom windows in the app (such as measurement and debug windows) properly forward orientation and rotation behaviors to match the main app's root view controller. The new navigation controller replaces standardUINavigationControllerinstances in relevant window managers.Orientation Handling Improvements:
OrientationForwardingNavigationControllerclass that overrides rotation and orientation properties to forward them from the app's root view controller, ensuring consistent interface orientation across custom windows.Integration into Window Managers:
MeasurementWindowManagerto useOrientationForwardingNavigationControllerinstead ofUINavigationControllerfor its measurement window.WindowManagerto useOrientationForwardingNavigationControllerinstead ofUINavigationControllerfor its alert-level window.Type of change
Test plan
Manual test steps
Screenshots / recordings (if applicable)
Checklist