Add a live, read-only CLI smoke test - #25
Open
daveosterjr wants to merge 1 commit into
Open
daveosterjr wants to merge 1 commit into
daveosterjr wants to merge 1 commit into
Conversation
npm run smoke:live builds the CLI and runs the real dm binary against DM_API_URL with DM_API_KEY in a temporary home directory. A local relay refuses non-allowlisted requests and checks the CLI source header. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
npm run smoke:live, which runs the real builtdmbinary against a live API. Before this, every CLI test was mocked.DM_API_URL(for examplehttps://api-staging.v2.dealmachine.com/v1) andDM_API_KEY. If either is missing, it exits 1 and names the variable. The key is never printed.--version,account,filters,fields, and a property search with--estimate-costonly. A local relay refuses any request outside that read-only list before it leaves the machine, and checks theX-DealMachine-Source: cliheader, the User-Agent and the auth on every request.Related: Factory https://github.com/DealMachine/dealmachine-factory/pull/139 registers
cli:smoke:liveas a scripted regression check against staging.Validation:
npm run checkpasses after rebasing onto master.npm run test:packagepasses.Not verified: a run against staging (no QA key yet), and Windows.
🤖 Generated with Claude Code