Repository navigation
Return empty string from STRAFTER/STRBEFORE when there is no match - #82
Open
MathiasVDA wants to merge 1 commit into
Open
MathiasVDA wants to merge 1 commit into
MathiasVDA wants to merge 1 commit into
Conversation
SPARQL 1.1 17.4.3.9/17.4.3.10: if the second argument does not occur in the first, an empty simple literal is returned. Previously the whole first argument was returned. Refs DataTreehouse#79. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias
Fixes #79.
Before: when the second argument does not occur in the first,
STRAFTERandSTRBEFOREreturned the whole first argument, e.g.STRAFTER("abc", "xyz")="abc".After: they return the empty string, as SPARQL 1.1 §17.4.3.9 and §17.4.3.10 require:
STRAFTER("abc", "xyz")="",STRBEFORE("abc", "xyz")="". Matches and empty second arguments behave as before.How: the
Nonebranch of thefindinstr_afterandstr_beforenow returnsSome("").One gap remains for language-tagged input: with no match, the result keeps its tag (
""@en), while the spec asks for an empty simple literal. Fixing that needs a per-row result type, so I left it out of this change.Tests:
py_maplib/tests/test_str_before_after.py(11 cases: simple and language-tagged literals, plus values read from a graph).🤖 Generated with Claude Code