Skip to content

Validate knowledge edits before activating them - #494

Open
alexeygrigorev wants to merge 9 commits into
mainfrom
fix/knowledge-save-gates
Open

alexeygrigorev wants to merge 9 commits into
mainfrom
fix/knowledge-save-gates

Conversation

@alexeygrigorev

@alexeygrigorev alexeygrigorev commented Nov 22, 2026 •

Copy link
Copy Markdown
Member

Web and CLI knowledge saves currently publish content before the repository's authored-content gates run. Incomplete metadata or controls can therefore break the nightly mirror. Stage the proposed publication privately, dispatch the canonical gate workflow, and preserve the active publication until the exact candidate has a passing receipt. Pending and failed decisions return visible errors with the validation link; retrying an unchanged passing edit completes its save.

Receipts bind the full base publication, actor, and effective final mutation bytes, including ordered edit/rename batches and restore. Only the verified main-branch workflow identity can record decisions. Its validator credential cannot publish knowledge or sync runtime templates. Ordinary publisher requests retain their existing gate-backed publication route. Companion workflow: DataTalksClub/dataops-knowledge#42 and #43.

Runtime Template creation, pinning and reset preflight their exact next derived publication before writing the source version. A pending or failed gate leaves the stored Template and knowledge revision unchanged; retrying with approval completes both writes. SOP step markers also keep adjacent numbered steps in one Document list, preserving their displayed 1..N order.

Validation: 31 targeted runtime Template tests pass, including pending/rejected/approved updates and a gated reset; 40 targeted knowledge/store/content-API tests pass. Portal and OIDC auth tests pass. Thirteen block-model tests pass. Real Chromium renders live-source QnA and podcast SOPs with sequential 1..4 and 1..9 steps and repaired controls. Full suites run in CI under host rule t2558u. Intake: 9043c08e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant