Validate cube dimension reachability during deployment - #2383
Open
saisharan0103 wants to merge 2 commits into
Open
Validate cube dimension reachability during deployment#2383saisharan0103 wants to merge 2 commits into
saisharan0103 wants to merge 2 commits into
Conversation
added 2 commits
August 1, 2026 14:18
…ble functions (LATERAL VIEW) — raises DJNotImplementedException Closes DataJunction#2265
… cube metrics at deployment time Closes DataJunction#2249
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2249
Root cause: deployment cube validation checked that referenced metric nodes and dimension attributes exist, but per-cube validation did not fail when a declared dimension was absent from the dimension-link graph of a metric's ultimate non-metric parent. That allowed
dj pushto create or update a syntactically valid cube whose metric parent transforms could not join to every declared dimension, with the failure surfacing later during SQL generation.Approach:
INVALID_DIMENSIONerrors for missing paths before creating the cube revision.Files modified:
datajunction-server/datajunction_server/internal/deployment/orchestrator.pydatajunction-server/tests/internal/deployment/orchestration_test.pyfix_plan.jsonLOC: +82 / -30
ruff check datajunction-server/datajunction_server/internal/deployment/orchestrator.py datajunction-server/tests/internal/deployment/orchestration_test.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.