fix(capabilities): copy wasm request bodies before send#182
Open
bengl wants to merge 1 commit into
Open
Conversation
Node can queue ClientRequest writes before a socket is assigned. Passing a Uint8Array view over wasm memory lets a later memory.grow detach the queued buffer, which can throw from _flushOutput outside the transport retry path. Copy the request body into Node-owned memory for each attempt before writing it. The head is still parsed from the current wasm memory view and response handling is unchanged.
Overall package sizeSelf size: 30.16 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Copy WASM-backed request bodies into Node-owned memory before passing them to
http.request().write().Why
Node can queue
ClientRequestwrites before a socket is assigned. If the queued chunk is aUint8Arrayview overWebAssembly.Memory, a latermemory.grow()detaches that buffer and Node can throw asynchronously from_flushOutput, outside the transport retry path.This matches the dd-trace-js system-test crash from PR 9139:
Verification
node --check crates/capabilities/src/http_transport.jsnode --check test/http_transport.jsnode --test test/http_transport.js