feat: added file capability [APMSP-3780]#177
Conversation
Aaalibaba42
changed the title
3d0021d to
9e13e69
Compare
Overall package sizeSelf size: 30.16 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
| # TODO: Replace this temporary libdatadog PR rev with the official release/tag | ||
| # that contains DataDog/libdatadog#2235, then regenerate Cargo.lock. | ||
| libdd-capabilities = { git = "https://github.com/DataDog/libdatadog.git", rev = "8cd68ab922fb7aade0f089ccfc91291d874673af" } | ||
| libdd-capabilities = { git = "https://github.com/DataDog/libdatadog.git", branch = "jwiriath/file-caps" } |
There was a problem hiding this comment.
TODO: change these before merging
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e13e690d3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,41 @@ | |||
| // Lazy `require('node:fs')` — see http_transport.js. | |||
There was a problem hiding this comment.
Very nit: Is it really transport ?
There was a problem hiding this comment.
mmh I mostly tried to have the same nomenclature as existing in the repository for the js side. Even sleep capability is part of the http_transport.js currently. I think it's something that could be worth refactoring at some point but idk if it's currently a big deal.
2 participants
What ?
Implement js side of FileCapabilities for interacting with the FS.
Why ?
Required #166 mentioned comment, these should be done by libdatadog so that libdatadog-nodejs don't need to get those infos like this.
How ?
New capability for interacting with FS driven by Rust