Repository navigation
Conversation
Contributor
CI Test ResultsRun: #38913801280 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-16 14:33:53 UTC |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix two errors in HotSpot continuation walking:
continueskippedJavaThread::_cont_entryandStubRoutines::_cont_returnBarrier.ContinuationEntrysize to two machine words before computing its entry frame pointer.Motivation
On JVM builds exporting continuation metadata,
cstack=vmxcould discover the entry type size but fail to resolve the current thread's entry, truncating samples atbreak_cont_entry_null. Fixing that lookup exposes the second error: HotSpot's exportedsizeof(ContinuationEntry)can be smaller than its stack allocation. The tested JDK 27 exports 56 bytes and requires 64, so adding the raw size places the frame pointer eight bytes too low.Additional Notes
The alignment matches HotSpot's shared ContinuationEntry::size() and the entry-frame calculation on both x86 and aarch64. It adds no allocations. Missing metadata remains optional, and already-aligned sizes remain unchanged.
How to test the change?
For Datadog employees: