Skip to content

Restore finalization metadata for Agent 7.83 releases - #25291

Merged
dkirov-dd merged 3 commits into
masterfrom
worktree-fix-7-83-finalization-metadata
Sep 21, 2026
Merged

dkirov-dd merged 3 commits into
masterfrom
worktree-fix-7-83-finalization-metadata

Conversation

@dkirov-dd

@dkirov-dd dkirov-dd commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Restores the missing finalization metadata on master for 7.83.0, 7.83.1, and 7.83.2, the complete set of existing final 7.83.x tags at the time of this audit.

  • Adds the three release sections to AGENT_CHANGELOG.md.
  • Adds the corresponding integration inventories to AGENT_INTEGRATIONS.md (260 pinned integration versions per release).
  • Adds 76 / Agent <version> annotations to existing release headings across 74 integration CHANGELOG.md files: 74 for 7.83.0 and two for 7.83.2.
  • Corrects the missing NGINX 9.4.1 → 10.0.0 breaking-change notice and fixes ddev's major-version comparison to use numeric inequality: both major upgrades and major downgrades receive a warning. Includes regression coverage and a ddev changelog entry.
Release Existing tag type Existing target commit Restored changelog metadata
7.83.0 Annotated bfd7b7350b73c62e8c718a3e7ae2ac4c4d56ad31 74 integration updates, compared with the preceding final release, 7.82.3
7.83.1 Lightweight bfd7b7350b73c62e8c718a3e7ae2ac4c4d56ad31 No integration updates; its integration inventory is identical to 7.83.0
7.83.2 Lightweight 7d5427214b13899f329696ac5ecbec96f477c9e1 ClickHouse 7.2.1 and Datadog Checks Base 38.0.3

This changes release metadata and the developer-tooling comparison that generates breaking-change notices. Existing historical sections, release dates, package versions, requirements, integration runtime code, and configuration are unchanged. No existing tags are deleted, replaced, moved, or modified, including release-candidate tags.

Motivation

The final-tag path used by ddev release branch tag --final creates and pushes an annotated tag. The tag-push workflow .github/workflows/update-agent-changelog.yml then generates the metadata using ddev release agent changelog, integrations, and integrations-changelog.

The audit confirms that 7.83.1 and 7.83.2 are lightweight tags; 7.83.0 is already annotated. Lightweight tags are usable by the metadata generators, so retagging is neither needed nor appropriate. The workflow-generated finalization PRs (#25089, #25152, #25228, and #25231) remain open against master. This PR consolidates the missing finalization records on master without changing those PRs or touching the tags.

This PR was retargeted from 7.83.x to master as requested. Only the metadata commit was rebased onto master; no release-branch code changes or release commits are included.

The records were generated with the ddev renderers, bounded to 7.83.0–7.83.2 (using 7.82.3 as the changelog comparison baseline). The changelog renderer's forced tag fetch was replaced with read-only tag-snapshot verification in the one-off invocation; the tool's fetch behavior is not changed by this PR. Only the new 7.83 sections were prepended, preserving all of master's existing history, including the 7.82.x sections and newer integration releases.

Review exposed a bug in the original renderer: comparing major versions as strings makes '9' < '10' false, omitting NGINX's breaking-change notice. The new Agent sections match the existing workflow-generated output in #25231 except for correcting that missing notice. The initial audit checked version pins and annotations but missed breaking-warning semantics; the expanded audit now verifies all four major-upgrade notices independently.

Validation:

  • ddev --no-interactive test ddev -- -q tests/cli/release/agent tests/cli/release/branch/test_tag.py: 102 passed, including major-upgrade, major-downgrade, minor-upgrade, and patch-upgrade cases. The Hatch test environment was created with the installed managed Python 3.13 because the local pyenv interpreter links incompatible Homebrew libraries.
  • Read-only audit verified every inventory pin against requirements-agent-release.txt at its existing tag, all release-to-release changelog deltas, all 76 annotations, unique/reverse-ordered release sections, and preservation of older content. The audit failed on the missing records before restoration and passed afterward.
  • Regression tests verify that both 9 → 10 upgrades and 10 → 9 downgrades are marked breaking; minor and patch upgrades within the same major remain non-breaking. The downgrade case fails with the upgrade-only predicate and passes with numeric inequality.
  • All four major upgrades in 7.83.0 have breaking-change notices: Checks Base, Kafka Consumer, KrakenD, and NGINX. No extra notices appear in 7.83.1 or 7.83.2.
  • Re-running the bounded generation with the corrected numeric comparison produces no further changes.
  • git diff --check: passed.
  • Snapshots of all local tags and all 18,637 remote tag/peeled refs are unchanged.
  • ddev --no-interactive test --lint ddev: reports an existing formatting issue in ddev/tests/repo/test_core.py. That file is byte-identical to origin/master (blob afcb6565e636ce8a0f8cbcf987a2eaa132d16b82) and is not changed by this PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required. — qa/skip-qa: release metadata and developer tooling; no Agent runtime changes.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.26% (+0.09%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 43b7731 | Docs | View more details | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7794a65185

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread AGENT_CHANGELOG.md Outdated
* MySQL [15.20.0](https://github.com/DataDog/integrations-core/blob/master/mysql/CHANGELOG.md)
* n8n [2.1.1](https://github.com/DataDog/integrations-core/blob/master/n8n/CHANGELOG.md)
* NGINX Ingress Controller [5.5.0](https://github.com/DataDog/integrations-core/blob/master/nginx_ingress_controller/CHANGELOG.md)
* NGINX [10.0.0](https://github.com/DataDog/integrations-core/blob/master/nginx/CHANGELOG.md)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark the NGINX 10 upgrade as breaking

For Agent 7.83.0, the inventory moves NGINX from 9.4.1 in 7.82.3 to 10.0.0, but this entry is the only major-version upgrade in the section without **BREAKING CHANGE**. Users consulting the restored Agent changelog will therefore miss the compatibility warning. This appears to expose the renderer's string comparison of major versions ('9' < '10' is false); add the notice here and ensure the renderer handles multi-digit majors numerically.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9f600b2. The 7.83.0 NGINX entry now has the breaking-change notice, and get_changes_per_agent compares integer major versions instead of strings. Added regression cases for 9.4.1 → 10.0.0, 10.0.0 → 9.4.1, and a same-major minor upgrade; the first two failed before the fix and all three pass afterward. The relevant release-tool suite passes (101 tests), and bounded regeneration reproduces the corrected metadata. The expanded audit verifies all four major-upgrade notices in 7.83.0, not merely agreement with the old renderer. Tags are unchanged.

Kyle-Neale
Kyle-Neale previously approved these changes Sep 21, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests · passed

Dispatcher beta: informational only

Dispatcher is running alongside existing CI while we validate it. You can ignore this report and its statuses. Existing CI remains the merge signal.

  2/2 jobs
✅ 2 passed · ❌ 0 failed

Batches

BatchStateJobsWorkflow
batch-01✅ passed2/2run 35612842233
Dispatcher finished on 9d8fc90 — GitHub Run.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   2 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@dd-octo-sts

dd-octo-sts Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

base_package ddev documentation downloader integration/active_directory integration/aerospike integration/amazon_msk integration/aspdotnet integration/boundary integration/cisco_aci integration/clickhouse integration/cockroachdb integration/directory integration/do_query_actions integration/dotnetclr integration/duckdb integration/envoy integration/esxi integration/exchange_server integration/falco integration/flink integration/gearmand integration/haproxy integration/hazelcast integration/http_check integration/ibm_ace integration/ibm_db2 integration/ibm_mq integration/iis integration/kafka_actions integration/kafka_consumer integration/kong integration/krakend integration/kueue integration/lustre integration/mapr integration/marklogic integration/mcache integration/milvus integration/mongo integration/mysql integration/n8n integration/nginx_ingress_controller integration/nginx integration/nutanix integration/openldap integration/openstack_controller integration/pdh_check integration/pgbouncer integration/postgres integration/prefect integration/process integration/prometheus integration/pulsar integration/ray integration/rethinkdb integration/riakcs integration/sap_hana integration/scylla integration/silverstripe_cms integration/slurm integration/snmp integration/spark integration/sqlserver integration/squid integration/ssh_check integration/supervisord integration/teleport integration/temporal integration/tibco_ems integration/tls integration/traffic_server integration/vsphere integration/win32_event_log integration/windows_service integration/wmi_check qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/container-integrations team/data-observability team/data-streams-monitoring team/database-monitoring team/documentation team/gpu-monitoring-agent team/ndm-integrations team/network-device-monitoring-core team/saas-integrations team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants