Restore finalization metadata for Agent 7.83 releases - #25291
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 43b7731 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7794a65185
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| * MySQL [15.20.0](https://github.com/DataDog/integrations-core/blob/master/mysql/CHANGELOG.md) | ||
| * n8n [2.1.1](https://github.com/DataDog/integrations-core/blob/master/n8n/CHANGELOG.md) | ||
| * NGINX Ingress Controller [5.5.0](https://github.com/DataDog/integrations-core/blob/master/nginx_ingress_controller/CHANGELOG.md) | ||
| * NGINX [10.0.0](https://github.com/DataDog/integrations-core/blob/master/nginx/CHANGELOG.md) |
There was a problem hiding this comment.
Mark the NGINX 10 upgrade as breaking
For Agent 7.83.0, the inventory moves NGINX from 9.4.1 in 7.82.3 to 10.0.0, but this entry is the only major-version upgrade in the section without **BREAKING CHANGE**. Users consulting the restored Agent changelog will therefore miss the compatibility warning. This appears to expose the renderer's string comparison of major versions ('9' < '10' is false); add the notice here and ensure the renderer handles multi-digit majors numerically.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 9f600b2. The 7.83.0 NGINX entry now has the breaking-change notice, and get_changes_per_agent compares integer major versions instead of strings. Added regression cases for 9.4.1 → 10.0.0, 10.0.0 → 9.4.1, and a same-major minor upgrade; the first two failed before the fix and all three pass afterward. The relevant release-tool suite passes (101 tests), and bounded regeneration reproduces the corrected metadata. The expanded audit verifies all four major-upgrade notices in 7.83.0, not merely agreement with the old renderer. Tags are unchanged.
✅ Dispatcher tests · passed
Batches
9d8fc90 — GitHub Run.
|
evalya-impact-summaryevalya impact analysis |
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Restores the missing finalization metadata on
masterfor 7.83.0, 7.83.1, and 7.83.2, the complete set of existing final 7.83.x tags at the time of this audit.AGENT_CHANGELOG.md.AGENT_INTEGRATIONS.md(260 pinned integration versions per release)./ Agent <version>annotations to existing release headings across 74 integrationCHANGELOG.mdfiles: 74 for 7.83.0 and two for 7.83.2.bfd7b7350b73c62e8c718a3e7ae2ac4c4d56ad31bfd7b7350b73c62e8c718a3e7ae2ac4c4d56ad317d5427214b13899f329696ac5ecbec96f477c9e1This changes release metadata and the developer-tooling comparison that generates breaking-change notices. Existing historical sections, release dates, package versions, requirements, integration runtime code, and configuration are unchanged. No existing tags are deleted, replaced, moved, or modified, including release-candidate tags.
Motivation
The final-tag path used by
ddev release branch tag --finalcreates and pushes an annotated tag. The tag-push workflow.github/workflows/update-agent-changelog.ymlthen generates the metadata usingddev release agent changelog,integrations, andintegrations-changelog.The audit confirms that 7.83.1 and 7.83.2 are lightweight tags; 7.83.0 is already annotated. Lightweight tags are usable by the metadata generators, so retagging is neither needed nor appropriate. The workflow-generated finalization PRs (#25089, #25152, #25228, and #25231) remain open against
master. This PR consolidates the missing finalization records onmasterwithout changing those PRs or touching the tags.This PR was retargeted from
7.83.xtomasteras requested. Only the metadata commit was rebased ontomaster; no release-branch code changes or release commits are included.The records were generated with the ddev renderers, bounded to 7.83.0–7.83.2 (using 7.82.3 as the changelog comparison baseline). The changelog renderer's forced tag fetch was replaced with read-only tag-snapshot verification in the one-off invocation; the tool's fetch behavior is not changed by this PR. Only the new 7.83 sections were prepended, preserving all of master's existing history, including the 7.82.x sections and newer integration releases.
Review exposed a bug in the original renderer: comparing major versions as strings makes
'9' < '10'false, omitting NGINX's breaking-change notice. The new Agent sections match the existing workflow-generated output in #25231 except for correcting that missing notice. The initial audit checked version pins and annotations but missed breaking-warning semantics; the expanded audit now verifies all four major-upgrade notices independently.Validation:
ddev --no-interactive test ddev -- -q tests/cli/release/agent tests/cli/release/branch/test_tag.py: 102 passed, including major-upgrade, major-downgrade, minor-upgrade, and patch-upgrade cases. The Hatch test environment was created with the installed managed Python 3.13 because the local pyenv interpreter links incompatible Homebrew libraries.requirements-agent-release.txtat its existing tag, all release-to-release changelog deltas, all 76 annotations, unique/reverse-ordered release sections, and preservation of older content. The audit failed on the missing records before restoration and passed afterward.git diff --check: passed.ddev --no-interactive test --lint ddev: reports an existing formatting issue inddev/tests/repo/test_core.py. That file is byte-identical toorigin/master(blobafcb6565e636ce8a0f8cbcf987a2eaa132d16b82) and is not changed by this PR.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required. —qa/skip-qa: release metadata and developer tooling; no Agent runtime changes.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged