[network] Collect ENA receive checksum errors - #25280
jaredledvina wants to merge 1 commit into
Conversation
✅ Dispatcher tests · passed
Batches
22b7ed1 — GitHub Run.
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed 🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 216edf2 | Docs | View more details | Give us feedback! |
evalya-impact-summaryevalya impact analysis |
Disk usage changeCommit Uncompressed
Details
Compressed
Details
|
Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>
61b1d45 to
216edf2
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Adds the per-queue ENA
rx_csum_badethtool statistic to thenetworkcheck's ENA allowlist, collected assystem.net.ena.queue.rx_csum_bad, and documents it innetwork/metadata.csv.Motivation
Linux 5.17 renamed the ENA receive checksum error ethtool statistic from
rx_bad_csumtorx_csum_bad(thestruct ena_stats_rxfield went frombad_csumtocsum_bad), so the check silently stopped collecting it on newer kernels. Both spellings are now allowlisted; a host reports only one of them, so on hosts that cross the 5.17 boundarysystem.net.ena.queue.rx_bad_csumgoes quiet andsystem.net.ena.queue.rx_csum_badappears in its place.Companion to DataDog/datadog-agent#55411, which makes the same change in the Go
networkv2check.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged