Skip to content

[network] Collect ENA receive checksum errors - #25280

Open
jaredledvina wants to merge 1 commit into
masterfrom
jared.ledvina/fixup-ena-rx-csum-bad-metric
Open

jaredledvina wants to merge 1 commit into
masterfrom
jared.ledvina/fixup-ena-rx-csum-bad-metric

Conversation

@jaredledvina

Copy link
Copy Markdown
Member

What does this PR do?

Adds the per-queue ENA rx_csum_bad ethtool statistic to the network check's ENA allowlist, collected as system.net.ena.queue.rx_csum_bad, and documents it in network/metadata.csv.

Motivation

Linux 5.17 renamed the ENA receive checksum error ethtool statistic from rx_bad_csum to rx_csum_bad (the struct ena_stats_rx field went from bad_csum to csum_bad), so the check silently stopped collecting it on newer kernels. Both spellings are now allowlisted; a host reports only one of them, so on hosts that cross the 5.17 boundary system.net.ena.queue.rx_bad_csum goes quiet and system.net.ena.queue.rx_csum_bad appears in its place.

Companion to DataDog/datadog-agent#55411, which makes the same change in the Go networkv2 check.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests · passed

Dispatcher beta: informational only

Dispatcher is running alongside existing CI while we validate it. You can ignore this report and its statuses. Existing CI remains the merge signal.

  4/4 jobs
✅ 4 passed · ❌ 0 failed

Batches

BatchStateJobsWorkflow
batch-01✅ passed4/4run 35387032932
Dispatcher finished on 22b7ed1 — GitHub Run.

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Pipelines  Tests  Code Coverage

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

Validate repository | Run Validations / Validate

View more details · View in GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 77.38% (-12.78%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 216edf2 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (3 files):
  network/changelog.d/25280.added
  network/datadog_checks/network/const.py
  network/metadata.csv

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Disk usage change

Commit 216edf2 compared against 22b7ed1.

Uncompressed

linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
🔺 +23 B 🔺 +23 B 🔺 +23 B 🔺 +23 B 🔺 +23 B
Details
Name Version Type linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
network 5.7.0 Integration 🔺 +23 B 🔺 +23 B 🔺 +23 B 🔺 +23 B 🔺 +23 B

Compressed

linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
🔺 +6 B 🔺 +6 B 🔺 +6 B 🔺 +6 B 🔺 +6 B
Details
Name Version Type linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
network 5.7.0 Integration 🔺 +6 B 🔺 +6 B 🔺 +6 B 🔺 +6 B 🔺 +6 B

Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com>
@jaredledvina
jaredledvina force-pushed the jared.ledvina/fixup-ena-rx-csum-bad-metric branch from 61b1d45 to 216edf2 Compare September 18, 2026 19:36
@jaredledvina
jaredledvina marked this pull request as ready for review September 18, 2026 19:44
@jaredledvina
jaredledvina requested review from a team as code owners September 18, 2026 19:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T19:46:26.208451Z 216edf2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jaredledvina jaredledvina added the qa/skip-qa Automatically skip this PR for the next QA label Sep 18, 2026
@clarkb7
clarkb7 removed request for a team and clarkb7 September 21, 2026 16:04
@chouetz chouetz added the internal Identify a non-fork PR label Oct 2, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants