Skip to content

dashboard and metadata fixes - #25278

Open
steveny91 wants to merge 4 commits into
masterfrom
sy/infiniband-counter-correctness
Open

steveny91 wants to merge 4 commits into
masterfrom
sy/infiniband-counter-correctness

Conversation

@steveny91

@steveny91 steveny91 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Fixed dashboards
  • Collect req_transport_retries_exceeded and req_rnr_retries_exceeded

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests · passed

Dispatcher beta: informational only

Dispatcher is running alongside existing CI while we validate it. You can ignore this report and its statuses. Existing CI remains the merge signal.

  2/2 jobs
✅ 2 passed · ❌ 0 failed

Batches

BatchStateJobsWorkflow
batch-01✅ passed2/2run 35365460604
Dispatcher finished on 0952d3dGitHub Run.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   2 (always emitted)
Diff (14 files):
  infiniband/README.md
  infiniband/assets/configuration/spec.yaml
  infiniband/assets/dashboards/infiniband_overview.json
  infiniband/assets/dashboards/infiniband_overview_k8s.json
  infiniband/assets/monitors/physical_state.json
  infiniband/changelog.d/25278.added
  infiniband/changelog.d/25278.changed
  infiniband/changelog.d/25278.fixed
  infiniband/datadog_checks/infiniband/check.py
  infiniband/datadog_checks/infiniband/data/conf.yaml.example
  infiniband/datadog_checks/infiniband/metrics.py
  infiniband/metadata.csv
  infiniband/tests/common.py
  infiniband/tests/test_unit.py

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 18, 2026

Copy link
Copy Markdown

Tests  Code Coverage

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 95.12%
Overall Coverage: 89.15%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6e80559 | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Monitor Template Quality Assessment

This check validates the notification message quality of monitor templates changed in this PR. Each monitor template message is evaluated against the recommended sections (What's Happening, Impact, Why, How to Troubleshoot, Related Links) as described in the Datadog monitor notification guidelines.

1 monitors analyzed across 1 integrations.

  • 1 monitors have missing sections
  • Most common missing sections: WHATS_HAPPENING, IMPACT, WHY
Monitors with missing sections
Integration Monitor File Owner Missing Sections
infiniband [InfiniBand] Port Physical State Alert infiniband/assets/monitors/physical_state.json agent-integrations WHATS_HAPPENING, IMPACT, WHY, HOW_TO_TROUBLESHOOT, RELATED_LINKS

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Disk usage change

Commit 6e80559 compared against 5329e6e.

Uncompressed

linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
🔺 +3.05 KiB 🔺 +3.05 KiB 🔺 +3.05 KiB 🔺 +3.05 KiB 🔺 +3.05 KiB
Details
Name Version Type linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
infiniband 1.7.0 Integration 🔺 +3.05 KiB 🔺 +3.05 KiB 🔺 +3.05 KiB 🔺 +3.05 KiB 🔺 +3.05 KiB

Compressed

linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
🔺 +1.16 KiB 🔺 +1.16 KiB 🔺 +1.16 KiB 🔺 +1.16 KiB 🔺 +1.16 KiB
Details
Name Version Type linux-aarch64 linux-x86_64 macos-aarch64 macos-x86_64 windows-x86_64
infiniband 1.7.0 Integration 🔺 +1.16 KiB 🔺 +1.16 KiB 🔺 +1.16 KiB 🔺 +1.16 KiB 🔺 +1.16 KiB

@steveny91 steveny91 added the qa/skip-qa Automatically skip this PR for the next QA label Sep 18, 2026
@steveny91
steveny91 marked this pull request as ready for review September 18, 2026 15:30
@steveny91
steveny91 requested review from a team as code owners September 18, 2026 15:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a02afd85ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread infiniband/changelog.d/25278.fixed Outdated
Comment thread infiniband/assets/dashboards/infiniband_overview.json Outdated
Comment thread infiniband/datadog_checks/infiniband/check.py Outdated
Comment thread infiniband/changelog.d/25278.added Outdated
@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants